Smack (4.2)

• 

  Florian Schmaus <flo@geekplace.eu> 09 Nov 2017 fe61922fb75a11999d50c202800089fee8ba044a

  Merge pull request #179 from damencho/4.2
  Makes xmpperror descriptive text optional as said in the rfc.
• 

  Florian Schmaus <flo@geekplace.eu> 09 Nov 2017 a66c42834fe93c6a0fb221be3aee43f5278aa50a

  Add findServicesDiscoveryInfo() variant
  which does not log some exceptions, but instead comes with an optional
  output paramater which returns the encountered exceptions.

  • smack-extensions/src/main/java/org/jivesoftware/smackx/disco/ServiceDiscoveryManager.java (version a66c42834fe93c6a0fb221be3aee43f5278aa50a)
• 

  Florian Schmaus <flo@geekplace.eu> 07 Nov 2017 5ef6853db6873115d53d9bb65780b6f5a8d549f9

  Improve MultiUserChat's leave() and destroy() login
  Remove the "if (!joined) return" guard in leave() this allows to
  resync the instances state with the real world state in case they ever
  get out of sync.
  
  Also call userHasLeft() in even if leave() throws and in certain
  situations if destroy() throws.
  
  Thanks to Дамян Минков and Ingo Bauersachs for pointing this out.

  • smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java (version 5ef6853db6873115d53d9bb65780b6f5a8d549f9)
• 

  Florian Schmaus <flo@geekplace.eu> 07 Nov 2017 0a4cd79d4ea0111dbe7e25e8ca191a2c40b53bed

  Call MultiUserChat.userHasLeft() before invoking listeners
  in case a listener throws, userHasLeft() will eventually have set the
  MutliUserChat instance to the right state.

  • smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java (version 0a4cd79d4ea0111dbe7e25e8ca191a2c40b53bed)
• 

  damencho <damencho@jitsi.org> 07 Nov 2017 44e4607259fddf0c3d6b75ea78cb01ef4583e3ed

  Fix memory leak in MutliUserChat.removeConnectionCallback().
  Fix memory leak by removing subject listener
  in MutliUserChat.removeConnectionCallback().
  Fixes SMACK-782.

  • smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java (version 44e4607259fddf0c3d6b75ea78cb01ef4583e3ed)
• 

  Florian Schmaus <flo@geekplace.eu> 07 Nov 2017 d93d214f0eda649be34d6cc3f616ead74d46ee49

  Remove duplicate code in MultiUserChat

  • smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java (version d93d214f0eda649be34d6cc3f616ead74d46ee49)
• 

  Florian Schmaus <flo@geekplace.eu> 06 Nov 2017 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7

  Add SubscribeAnswer.ApproveAndAlsoRequestIfRequired

  • smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7)
  • smack-core/src/main/java/org/jivesoftware/smack/StanzaListener.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7)
  • smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/DataListener.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7)
  • smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamSession.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7)
  • smack-im/src/main/java/org/jivesoftware/smack/roster/Roster.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7)
  • smack-im/src/main/java/org/jivesoftware/smack/roster/SubscribeListener.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7)
  • smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7)
• 

  Florian Schmaus <flo@geekplace.eu> 06 Nov 2017 9a34e9e870447588c350dca8199a6b07ad32e773

  Add RosterUtil.preApproveSubscriptionIfRequiredAndPossible()

  • smack-im/src/main/java/org/jivesoftware/smack/roster/RosterUtil.java (version 9a34e9e870447588c350dca8199a6b07ad32e773)
• 

  Florian Schmaus <flo@geekplace.eu> 27 Oct 2017 1d52a0c8ef9afcc8bb07ce1a755987884cdd0a1f

  Don't let smack-android depend on smack-omemo(-signal)
  Fixes SMACK-779.

  • build.gradle (version 1d52a0c8ef9afcc8bb07ce1a755987884cdd0a1f)
  • smack-android/build.gradle (version 1d52a0c8ef9afcc8bb07ce1a755987884cdd0a1f)
• 

  damencho <damencho@jitsi.org> 27 Oct 2017 a0b0b5a63b7aafd034aa215e7174653a59f8d7c8

  Makes xmpperror descriptive text optional as said in the rfc.

  • smack-core/src/main/java/org/jivesoftware/smack/packet/XMPPError.java (version a0b0b5a63b7aafd034aa215e7174653a59f8d7c8)
• 

  Florian Schmaus <flo@geekplace.eu> 27 Oct 2017 1b2521269e04c57dcb0e3ddc6b71a2bb63815e5d

  Make END_TAG parsing more NPE robust
  by calling String.equals() on the constant string and not on the
  return value of parser.getName().
  
  Also perform the access to 'parser' on a different LOC than
  equals(). This should help debugging things like
  
  okt 25, 2017 2:02:54 PM org.jivesoftware.smack.AbstractXMPPConnection callConnectionClosedOnErrorListener
  WARNING: Connection XMPPTCPConnection[***@***/***] (0) closed with error
  java.lang.NullPointerException
          at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.parsePackets(XMPPTCPConnection.java:1194)
          at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.access$300(XMPPTCPConnection.java:982)
          at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader$1.run(XMPPTCPConnection.java:998)
          at java.lang.Thread.run(Thread.java:745)
  
  which where recently reported on the forums.

  • smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 1b2521269e04c57dcb0e3ddc6b71a2bb63815e5d)