Build: #70 was successful Changes by Florian Schmaus <flo@geekplace.eu>
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> 81002c4fbd521c9869c482f330c4e69e5df417a7
Merge branch '4.2'
-
Florian Schmaus <flo@geekplace.eu> 853324a998d314c0133629cf60f1b35e56bc3500 m
Merge pull request #185 from mityada/sm-resumption-race-condition
Prevent race condition after stream resumption -
Florian Schmaus <flo@geekplace.eu> af0c1832fdaa7a7a06ec13ed13ccbe2804b9ce6a m
Update gettingstarted.md
-
Florian Schmaus <flo@geekplace.eu> 813a5ba63f9fd5cda8bd97b2d3eafd9a097f4ebe m
Merge pull request #184 from mityada/stream-management-exception
Drop stream management state on StreamManagementException -
Florian Schmaus <flo@geekplace.eu> 7d1356bf4688c47bd8767f181ce8cea0b6dd8558 m
Merge pull request #186 from vanitasvitae/fixCheckstyleRule
Fix comment checkstyle rule description -
Florian Schmaus <flo@geekplace.eu> 5ff4387f682bd04ac77f9ae04767c9c9835e924c m
Fix Presence.getPriority() to not return Integer.MIN_VALUE
Fixes SMACK-787. -
Florian Schmaus <flo@geekplace.eu> 4775f350ae14da8a7dfe022dd3bd3798a754ceae m
Add javadoc to Presence.priority
-
vanitasvitae <vanitasvitae@fsfe.org> cc94cb8ea280c6d3a73c800660b2f2f4eb18ed61 m
Fix comment checkstyle rule description
-
Florian Schmaus <flo@geekplace.eu> 9e11b6814478ba5773ff40ac36990d5011e41446 m
Add comment style checkstyle rule requiring a space
- config/checkstyle.xml (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-bosh/src/main/java/org/jivesoftware/smack/bosh/XMPPBOSHConnection.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/proxy/Socks5ProxySocketConnection.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-core/src/test/java/org/jivesoftware/smack/StanzaCollectorTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/disco/ServiceDiscoveryManager.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/OutgoingFileTransfer.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/packet/VCard.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-extensions/src/test/java/org/jivesoftware/smackx/iqversion/VersionTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-extensions/src/test/java/org/jivesoftware/smackx/ping/PingTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-extensions/src/test/java/org/jivesoftware/smackx/xdata/packet/DataFormTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/mam/MamIntegrationTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/omemo/AbstractOmemoIntegrationTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/omemo/OmemoInitializationTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/omemo/OmemoIntegrationTestHelper.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/omemo/OmemoKeyTransportTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/omemo/OmemoMessageSendingTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/omemo/OmemoStoreTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/JingleNegotiator.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/JingleSession.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/JingleSessionRequest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/JingleSessionStatePending.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/media/MediaNegotiator.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/JMFInit.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/jmf/JmfMediaManager.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/sshare/api/ImageReceiver.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/ICECandidate.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/ICEResolver.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/TcpUdpBridgeClient.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/TcpUdpBridgeServer.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/TransportCandidate.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/TransportNegotiator.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/provider/JingleTransportProvider.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoKeyUtil.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoStoreConnector.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/FileBasedOmemoStore.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoManager.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoService.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoStore.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/internal/OmemoSession.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/util/OmemoConstants.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/util/OmemoMessageBuilder.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-omemo/src/test/java/org/jivesoftware/smack/omemo/OmemoConfigurationTest.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 9e11b6814478ba5773ff40ac36990d5011e41446) (diffs)
-
Dmitry Deshevoy <mityada@gmail.com> 230a226424e4219f07cffe3f0130ce67fa830b0e m
Prevent race condition after stream resumption
New stanzas sent directly after stream resumption might have been added
to unacknowledgedStanzas before the old unacknowledged stanzas
are resent. This caused new stanzas to be sent twice and later led
to a StreamManagementCounterError.
Fixes SMACK-786 -
Florian Schmaus <flo@geekplace.eu> 52bd680bb573f8d94cd2eaa2d21e694c82f6d1a6 m
Fix OfflineMessageManager.getMessages(List<STring>)
by implementing a new logic how the messages are retrieved.
Previously in case the node list has exactly one item, the method
would perform an unnecessary call to nextResult() causing a delay.
Fixes SMACK-785. -
Florian Schmaus <flo@geekplace.eu> 809ab6f42f0081147b0ceac087e92c46d3b88616 m
Bump jxmpp to 0.6.0
-
Florian Schmaus <flo@geekplace.eu> 2341bb4e230cd88559c8f41af50ea026b5a2a414 m
Remove duplicate code in StringUtils
-
Florian Schmaus <flo@geekplace.eu> 73dd46af21b6344dc403a425d785ba94fafaca85 m
Remove duplicate numbers from StringUtils.numbersAndLetters
Fixes SMACK-784. -
Dmitry Deshevoy <mityada@gmail.com> 4f11dc5b14ebe9b686a4c23a8b1d1fc9cc3c82a7 m
Drop stream management state on StreamManagementException
-
Florian Schmaus <flo@geekplace.eu> 0da3ebf38563d949d3505fb0417fd5fa4fdcb67e m
Make MUC invitation rejected filter also filter by room address
Fixes SMACK-783. -
Florian Schmaus <flo@geekplace.eu> fe61922fb75a11999d50c202800089fee8ba044a m
Merge pull request #179 from damencho/4.2
Makes xmpperror descriptive text optional as said in the rfc. -
Florian Schmaus <flo@geekplace.eu> a66c42834fe93c6a0fb221be3aee43f5278aa50a m
Add findServicesDiscoveryInfo() variant
which does not log some exceptions, but instead comes with an optional
output paramater which returns the encountered exceptions. -
Florian Schmaus <flo@geekplace.eu> 5ef6853db6873115d53d9bb65780b6f5a8d549f9 m
Improve MultiUserChat's leave() and destroy() login
Remove the "if (!joined) return" guard in leave() this allows to
resync the instances state with the real world state in case they ever
get out of sync.
Also call userHasLeft() in even if leave() throws and in certain
situations if destroy() throws.
Thanks to Дамян Минков and Ingo Bauersachs for pointing this out. -
damencho <damencho@jitsi.org> 44e4607259fddf0c3d6b75ea78cb01ef4583e3ed m
Fix memory leak in MutliUserChat.removeConnectionCallback().
Fix memory leak by removing subject listener
in MutliUserChat.removeConnectionCallback().
Fixes SMACK-782. -
Florian Schmaus <flo@geekplace.eu> 0a4cd79d4ea0111dbe7e25e8ca191a2c40b53bed m
Call MultiUserChat.userHasLeft() before invoking listeners
in case a listener throws, userHasLeft() will eventually have set the
MutliUserChat instance to the right state. -
Florian Schmaus <flo@geekplace.eu> d93d214f0eda649be34d6cc3f616ead74d46ee49 m
Remove duplicate code in MultiUserChat
-
Florian Schmaus <flo@geekplace.eu> 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7 m
Add SubscribeAnswer.ApproveAndAlsoRequestIfRequired
- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/StanzaListener.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/DataListener.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamSession.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7) (diffs)
- smack-im/src/main/java/org/jivesoftware/smack/roster/Roster.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7) (diffs)
- smack-im/src/main/java/org/jivesoftware/smack/roster/SubscribeListener.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 65b4f506dca9dbe81427ceaba54ee3ef886dc2d7) (diffs)
-
Florian Schmaus <flo@geekplace.eu> 9a34e9e870447588c350dca8199a6b07ad32e773 m
Add RosterUtil.preApproveSubscriptionIfRequiredAndPossible()
-
Florian Schmaus <flo@geekplace.eu> 1d52a0c8ef9afcc8bb07ce1a755987884cdd0a1f m
Don't let smack-android depend on smack-omemo(-signal)
Fixes SMACK-779. -
damencho <damencho@jitsi.org> a0b0b5a63b7aafd034aa215e7174653a59f8d7c8 m
Makes xmpperror descriptive text optional as said in the rfc.
-
Florian Schmaus <flo@geekplace.eu> 1b2521269e04c57dcb0e3ddc6b71a2bb63815e5d m
Make END_TAG parsing more NPE robust
by calling String.equals() on the constant string and not on the
return value of parser.getName().
Also perform the access to 'parser' on a different LOC than
equals(). This should help debugging things like
okt 25, 2017 2:02:54 PM org.jivesoftware.smack.AbstractXMPPConnection callConnectionClosedOnErrorListener
WARNING: Connection XMPPTCPConnection[***@***/***] (0) closed with error
java.lang.NullPointerException
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.parsePackets(XMPPTCPConnection.java:1194)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader.access$300(XMPPTCPConnection.java:982)
at org.jivesoftware.smack.tcp.XMPPTCPConnection$PacketReader$1.run(XMPPTCPConnection.java:998)
at java.lang.Thread.run(Thread.java:745)
which where recently reported on the forums.
Smack (4.2)
-
Florian Schmaus <flo@geekplace.eu> 32f681c6e5bf14ecf6138edee3f24748f69cd152
Initialize keytsoreType with KeyStore.getDefaultType()
- smack-core/src/main/java/org/jivesoftware/smack/ConnectionConfiguration.java (version 32f681c6e5bf14ecf6138edee3f24748f69cd152)
-
Florian Schmaus <flo@geekplace.eu> 853324a998d314c0133629cf60f1b35e56bc3500
Merge pull request #185 from mityada/sm-resumption-race-condition
Prevent race condition after stream resumption -
Dmitry Deshevoy <mityada@gmail.com> 230a226424e4219f07cffe3f0130ce67fa830b0e m
Prevent race condition after stream resumption
New stanzas sent directly after stream resumption might have been added
to unacknowledgedStanzas before the old unacknowledged stanzas
are resent. This caused new stanzas to be sent twice and later led
to a StreamManagementCounterError.
Fixes SMACK-786- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version 230a226424e4219f07cffe3f0130ce67fa830b0e)