Build #199

Plan branch:
Builds Spark (minus the Install4j distributables) after every change to the code.

Build: #199 was successful Changes by Guus der Kinderen and wroot <wrooot@users.noreply.github.com>

Code commits

Spark (master)

  • wroot <wrooot@users.noreply.github.com>

    wroot <wrooot@users.noreply.github.com> ee4c3ec03049a5e1c78b2bd8fa95c4fbef664ca0

    Merge pull request #498 from guusdk/SPARK-2110_missing-at-in-unescaped-jid
    SPARK-2110: Fix nicknames & add missing '@' in result of unescaping JIDs

  • Guus der Kinderen

    Guus der Kinderen b3538d54e55e74a163642164caa7cdcef2d8f1a0

    SPARK-2110: Don't escape nicknames
    org.jivesoftware.spark.UserManager#getUserNicknameFromJID(org.jxmpp.jid.BareJid) values should not be JID escaped, as that will mangle their content. The implementation of that method already appropriately escapes any JID parts that are used in the nickname.

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version b3538d54e55e74a163642164caa7cdcef2d8f1a0)
    • core/src/main/java/org/jivesoftware/spark/ui/VCardPanel.java (version b3538d54e55e74a163642164caa7cdcef2d8f1a0)
    • core/src/main/java/org/jivesoftware/spark/ui/VCardViewer.java (version b3538d54e55e74a163642164caa7cdcef2d8f1a0)
    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version b3538d54e55e74a163642164caa7cdcef2d8f1a0)
  • Guus der Kinderen

    Guus der Kinderen 2da2c6e38f3d3174e089ce1a81d36cb64ddc98b1

    SPARK-2110: Add missing '@' in result of unescaping JIDs
    The implementation that unescapes JIDs unintentionally removes the '@' character (separating node- and domain-part). This commit restores that character.

    • core/src/main/java/org/jivesoftware/spark/UserManager.java (version 2da2c6e38f3d3174e089ce1a81d36cb64ddc98b1)