Builds Spark (minus the Install4j distributables) after every change to the code.

Build: #260 was successful Changes by wroot <wrooot@users.noreply.github.com> and Guus der Kinderen

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
56 seconds
Labels
None
Revision
8fcf060f0000985f32014e318322f1c30d3ba0a1
Total tests
5
Successful since
#190 ()

Tests

  • 0 New failures
  • 0 Existing failures
  • 0 Fixed

Code commits

Author Commit Message Commit date
wroot <wrooot@users.noreply.github.com> wroot <wrooot@users.noreply.github.com> 8fcf060f0000985f32014e318322f1c30d3ba0a1 Merge pull request #550 from guusdk/fix-certchain-validation
Fix certchain validation
Guus der Kinderen Guus der Kinderen ade68fa13ce36785d6356c3512ffc7fb89d1215b SPARK-2187: Do not offer to add a cert to truststore on unrelated error
The go-to response for Spark is to add a certificate that failed validation to the truststore. That's fine for certs that it does not recognize, but if validation failed because of another reason, Spark should not (re)add the certificate. Instead, an error should be shown that explains what the issue is.
Guus der Kinderen Guus der Kinderen 81bb9b12dfd63cdad067e2700b9d1cc1350610e5 SPARK-2188: Exclude TrustAnchor from Certification Path to not confuse validation
As documented in its javadoc, the CertPath instance should not include the root CA certificate. If it does, validation errors can occur.
Guus der Kinderen Guus der Kinderen 163bd6de37860bb1bd313643fae949215e770889 SPARK-2185: Add safeguard against validating an empty chain
This exposes an issue with the existing code (which unintentionally validates an empty object, instead of a properly populated CarthPath object).
Guus der Kinderen Guus der Kinderen 2d66d651e49a5d2dd13366b76153d8a6e596a234 Refactoring, should not functionally change anything.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeSPARK-2184Could not obtain issue details from Jira
Unknown Issue TypeSPARK-2185Could not obtain issue details from Jira
Unknown Issue TypeSPARK-2186Could not obtain issue details from Jira
Unknown Issue TypeSPARK-2187Could not obtain issue details from Jira
Unknown Issue TypeSPARK-2188Could not obtain issue details from Jira