Build #261

Plan branch:
Builds Spark (minus the Install4j distributables) after every change to the code.

Code commits

Spark (master)

  • wroot <wrooot@users.noreply.github.com>

    wroot <wrooot@users.noreply.github.com> 0d57e949bff35a94b04dd5afb531f472f37166ad

    Merge pull request #551 from R87A/SPARK-1469
    SPARK-1469: Code cleanup

  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> fb616c83bff9d1069fe4f74c9858c3aa3d58a767

    SPARK-1469: Code cleanup: resolve performance issues related to string concatenations.

    • core/src/main/java/org/jivesoftware/MainWindow.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • core/src/main/java/org/jivesoftware/spark/ui/ContactGroup.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • core/src/main/java/org/jivesoftware/spark/util/StringUtils.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/CertificateModel.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/IdentityController.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/alerts/BroadcastPlugin.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/transcripts/HistoryTranscript.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/FormUtils.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/AgentConversation.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/ConversationItem.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/HistoryItem.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/search/ChatSearchResult.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/search/SearchItem.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/meet/src/main/java/de/mxro/process/Spawn.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
    • plugins/translator/src/main/java/org/jivesoftware/spark/translator/TranslatorUtil.java (version fb616c83bff9d1069fe4f74c9858c3aa3d58a767)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> cd7149f467fb2d60966a9e7eb91cebaf25528651

    SPARK-1469: Code cleanup: resolve some collections issues.
    Calls of toArray method using pre-sized array are not recommended since Java 6 release.

    • core/src/main/java/org/jivesoftware/spark/ui/ChatRoom.java (version cd7149f467fb2d60966a9e7eb91cebaf25528651)
    • core/src/main/java/org/jivesoftware/spark/util/GraphicUtils.java (version cd7149f467fb2d60966a9e7eb91cebaf25528651)
    • core/src/main/java/org/jivesoftware/spark/util/StringUtils.java (version cd7149f467fb2d60966a9e7eb91cebaf25528651)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/jabber/JabberBrowser.java (version cd7149f467fb2d60966a9e7eb91cebaf25528651)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/privacy/PrivacyManager.java (version cd7149f467fb2d60966a9e7eb91cebaf25528651)
    • core/src/main/java/org/jivesoftware/sparkimpl/search/users/UserSearchResults.java (version cd7149f467fb2d60966a9e7eb91cebaf25528651)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> e3ce1f19175f4a2fc0972987d168cf3637583307

    SPARK-1469: Code cleanup: remove Boolean constructor calls.

    • core/src/main/java/org/jivesoftware/sparkimpl/settings/local/LocalPreferences.java (version e3ce1f19175f4a2fc0972987d168cf3637583307)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 6aebc6d3817bf668c91111250f562a22eab19070

    SPARK-1469: Code cleanup: fix Javadoc references.
    Not such a major issue, but still generates errors due to code analysis.

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/spark/PresenceManager.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/spark/UserManager.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/spark/component/browser/BrowserFactory.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/spark/component/browser/BrowserViewer.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/spark/ui/history/XMLHistoryFile.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/spark/util/UIComponentRegistry.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/CertManager.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/CertificateController.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/GeneralTrustManager.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/alerts/BroadcastPlugin.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/filetransfer/transfer/Downloads.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/linux/LinuxIdleTime.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/mac/MacIdleTime.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/windows/Win32IdleTime.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/profile/VCardManager.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
    • core/src/main/java/org/jivesoftware/sparkimpl/settings/local/LocalPreferences.java (version 6aebc6d3817bf668c91111250f562a22eab19070)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> c6e4037aa146f44f565298d6b95e67259d9cfc31

    SPARK-1469: Code cleanup: replace iterations with bulk operations.

    • core/src/main/java/org/jivesoftware/spark/ui/ContactList.java (version c6e4037aa146f44f565298d6b95e67259d9cfc31)
    • core/src/main/java/org/jivesoftware/spark/ui/themes/ColorPreferencePanel.java (version c6e4037aa146f44f565298d6b95e67259d9cfc31)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/WorkgroupDataForm.java (version c6e4037aa146f44f565298d6b95e67259d9cfc31)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> ed533c02544919aeb1fcc81ea64a69b3c7badb43

    SPARK-1469: Code cleanup: delete unused imports.

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/spark/PresenceManager.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/spark/ui/ContactInfoWindow.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/spark/ui/ContactItem.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/spark/ui/VCardPanel.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/BookmarksUI.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceUtils.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/alerts/BuzzPlugin.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/chat/PresenceChangePlugin.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/gateways/GatewayPlugin.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/FastpathContainer.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/FastpathPlugin.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • plugins/growl/src/main/java/com/jivesoftware/spark/plugin/growl/GrowlTalker.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • plugins/meet/src/main/java/org/jivesoftware/spark/plugin/ofmeet/ChatRoomDecorator.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • plugins/meet/src/main/java/org/jivesoftware/spark/plugin/ofmeet/SparkMeetPlugin.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • plugins/reversi/src/main/java/org/jivesoftware/game/reversi/ReversiPlugin.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
    • plugins/roar/src/main/java/org/jivesoftware/spark/roar/displaytype/RoarPopupHelper.java (version ed533c02544919aeb1fcc81ea64a69b3c7badb43)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 25969f199093e7515bce97e225357d577c833df2

    SPARK-1469: Code cleanup: fix minor numeric issues.

    • core/src/main/java/org/jivesoftware/spark/component/tabbedPane/SparkTabbedPane.java (version 25969f199093e7515bce97e225357d577c833df2)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/filetransfer/transfer/ui/TransferUtils.java (version 25969f199093e7515bce97e225357d577c833df2)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/privacy/ui/PrivacyListTree.java (version 25969f199093e7515bce97e225357d577c833df2)