Build #264

Plan branch:
Builds Spark (minus the Install4j distributables) after every change to the code.

Code commits

Spark (master)

  • wroot <wrooot@users.noreply.github.com>

    wroot <wrooot@users.noreply.github.com> 50cadaf7ecdd7d6ac7b544e2b0e62d430937809b

    Merge pull request #554 from R87A/SPARK-1469
    SPARK-1469: Cleanup code

  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 0b4b174eef76beaf2b91f4b35029e32e4d196243

    SPARK-1469: Code cleanup: remove redundant local variables.

    • core/src/main/java/org/jivesoftware/MainWindow.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/PresenceManager.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/UserManager.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/component/DroppableFrame.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/ChatContainer.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceRoomBrowser.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceServiceBrowser.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/GroupChatParticipantList.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/InvitationDialog.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/history/HistoryWindow.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/themes/ColorSettingManager.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/ui/themes/ColorSettings.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/spark/util/ImageCombiner.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/IdentityController.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/gateways/transports/TransportUtils.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/transcripts/HistoryTranscript.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/sparkimpl/profile/ext/JabberAvatarExtension.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/sparkimpl/profile/ext/VCardUpdateExtension.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • core/src/main/java/org/jivesoftware/sparkimpl/settings/local/LocalPreferences.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/FormUtils.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/WorkgroupDataForm.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/util/RequestUtils.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • plugins/roar/src/main/java/org/jivesoftware/spark/roar/gui/RoarPreferencePanel.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
    • plugins/transferguard/src/main/java/org/jivesoftware/spark/plugins/transfersettings/TransferSettingsPanel.java (version 0b4b174eef76beaf2b91f4b35029e32e4d196243)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 96a097c649b5a7105efbe83ce47ab2b12da958ac

    SPARK-1469: Code cleanup: resolve control flow issues.

    • core/src/main/java/org/jivesoftware/spark/PresenceManager.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/UserManager.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/component/JContactItemField.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/component/JiveTreeNode.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/search/SearchManager.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/ui/ChatRoom.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/ui/ContactGroup.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/BookmarksUI.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceRoomBrowser.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceUtils.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/RoomCreationDialog.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/ui/themes/ThemePanel.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/spark/util/StringUtils.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/CertificateController.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/CertificateModel.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/IdentityController.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/PemHelper.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/SparkTrustManager.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/privacy/list/SparkPrivacyList.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/privacy/ui/PrivacyListTree.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/scratchpad/ScratchPadPlugin.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/scratchpad/TaskUI.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/profile/AvatarPanel.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • core/src/main/java/org/jivesoftware/sparkimpl/search/users/UserSearchForm.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/FormUtils.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/invite/WorkgroupInvitationDialog.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • plugins/fileupload/src/main/java/org/jivesoftware/spark/plugin/fileupload/SparkFileUploadPlugin.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • plugins/flashing/src/main/java/org/jivesoftware/spark/plugin/flashing/FlashWindow.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • plugins/tictactoe/src/main/java/tic/tac/toe/GameBoard.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • plugins/transferguard/src/main/java/org/jivesoftware/spark/plugins/transfersettings/FileTransferSettingsPlugin.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
    • plugins/translator/src/test/java/com/jivesoftware/spark/translator/TestTranslator.java (version 96a097c649b5a7105efbe83ce47ab2b12da958ac)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 8685a8cb190f667471c3664db054ea119bc24dac

    SPARK-1469: Code cleanup: make all error outputs use Log.error().

    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceRoomBrowser.java (version 8685a8cb190f667471c3664db054ea119bc24dac)
    • core/src/main/java/org/jivesoftware/sparkimpl/search/users/UserSearchForm.java (version 8685a8cb190f667471c3664db054ea119bc24dac)
    • core/src/main/java/org/jivesoftware/sparkimpl/settings/local/WinRegistryReader.java (version 8685a8cb190f667471c3664db054ea119bc24dac)
    • plugins/transferguard/src/main/java/org/jivesoftware/spark/plugins/transfersettings/FileTransferSettings.java (version 8685a8cb190f667471c3664db054ea119bc24dac)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 93d76d662feadc3a3054e95bd7786c0e5dc82b84

    SPARK-1469: Code cleanup: remove unused imports.

    • core/src/main/java/org/jivesoftware/spark/component/MessageDialog.java (version 93d76d662feadc3a3054e95bd7786c0e5dc82b84)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/GroupChatInvitationUI.java (version 93d76d662feadc3a3054e95bd7786c0e5dc82b84)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/chat/ChatArgumentsPlugin.java (version 93d76d662feadc3a3054e95bd7786c0e5dc82b84)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/assistants/UserHistory.java (version 93d76d662feadc3a3054e95bd7786c0e5dc82b84)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/invite/WorkgroupRosterTree.java (version 93d76d662feadc3a3054e95bd7786c0e5dc82b84)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/macros/MacrosEditor.java (version 93d76d662feadc3a3054e95bd7786c0e5dc82b84)