Build #273

Plan branch:
Builds Spark (minus the Install4j distributables) after every change to the code.

Code commits

Spark (master)

  • wroot <wrooot@users.noreply.github.com>

    wroot <wrooot@users.noreply.github.com> 54cc81346450d67db9643d0053395519dcd4f99d

    Merge pull request #563 from R87A/SPARK-1469
    SPARK-1469: Code cleanup

  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 506e744fbd4cbab2b282a135b6993f279b58fef5

    SPARK-1469: Code cleanup: Fix probable bugs: Remove unused assignment and redundant initializers

    • core/src/main/java/org/jivesoftware/spark/ButtonFactory.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/component/JiveSortableTable.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/component/Table.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/component/tabbedPane/SparkTab.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/component/tabbedPane/SparkTabbedPane.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/ui/BroadcastHistoryFrame.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/ui/ContactInfoWindow.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/ui/RosterDialog.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/AnswerFormDialog.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/DataFormDialog.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/InvitationDialog.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/spark/util/Base64.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/alerts/SparkToaster.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/emoticons/Emoticon.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/gateways/GatewayTabItem.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/idle/linux/LinuxIdleTime.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/privacy/PrivacyManager.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/privacy/list/SparkPrivacyList.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/transcripts/HistoryTranscript.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/profile/VCardManager.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • core/src/main/java/org/jivesoftware/sparkimpl/updater/EasyX509TrustManager.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/FormUtils.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/WorkgroupDataForm.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/Workpane.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/invite/WorkgroupRosterTree.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/AgentConversations.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/CurrentActivity.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/InvitationPane.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/UserInvitationPane.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/search/ChatSearch.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/fileupload/src/main/java/org/jivesoftware/spark/plugin/fileupload/SparkFileUploadPlugin.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/meet/src/main/java/org/jivesoftware/spark/plugin/ofmeet/SparkMeetPlugin.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
    • plugins/roar/src/main/java/org/jivesoftware/spark/roar/gui/SparkToaster.java (version 506e744fbd4cbab2b282a135b6993f279b58fef5)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> f6f273307dfef112c479edb2c4282b38500e8345

    SPARK-1469: Code cleanup: Fix probable bugs: Add NotNull annotations

    • core/src/main/java/org/jivesoftware/spark/component/FileDragLabel.java (version f6f273307dfef112c479edb2c4282b38500e8345)
    • core/src/main/java/org/jivesoftware/spark/component/JiveTreeNode.java (version f6f273307dfef112c479edb2c4282b38500e8345)
    • core/src/main/java/org/jivesoftware/spark/component/tabbedPane/SparkTabbedPane.java (version f6f273307dfef112c479edb2c4282b38500e8345)
    • core/src/main/java/org/jivesoftware/spark/ui/ChatRoomTransferHandler.java (version f6f273307dfef112c479edb2c4282b38500e8345)
    • core/src/main/java/org/jivesoftware/spark/ui/ContactGroupTransferHandler.java (version f6f273307dfef112c479edb2c4282b38500e8345)
    • core/src/main/java/org/jivesoftware/spark/util/Base64.java (version f6f273307dfef112c479edb2c4282b38500e8345)
    • core/src/main/java/org/jivesoftware/spark/util/ByteFormat.java (version f6f273307dfef112c479edb2c4282b38500e8345)
    • core/src/main/java/org/jivesoftware/spark/util/TaskEngine.java (version f6f273307dfef112c479edb2c4282b38500e8345)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 7e6c4db77421663966c6e637affa59003122e764

    SPARK-1469: Code cleanup: Fix probable bugs: Call to toString() on arrays

    • core/src/main/java/org/jivesoftware/spark/ui/BroadcastHistoryFrame.java (version 7e6c4db77421663966c6e637affa59003122e764)
    • core/src/main/java/org/jivesoftware/spark/ui/login/LoginSettingDialog.java (version 7e6c4db77421663966c6e637affa59003122e764)
    • core/src/main/java/org/jivesoftware/spark/util/UIComponentRegistry.java (version 7e6c4db77421663966c6e637affa59003122e764)
    • core/src/main/java/org/jivesoftware/sparkimpl/certificates/CertificateModel.java (version 7e6c4db77421663966c6e637affa59003122e764)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/alerts/BroadcastDialog.java (version 7e6c4db77421663966c6e637affa59003122e764)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> caaf9db56fc98526b9e794b93283f320ccc6bb30

    SPARK-1469: Code cleanup: Fix probable bugs: Remove empty statements.
    Also remove the code that does nothing.

    • core/src/main/java/org/jivesoftware/launcher/Installer.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/component/CheckTree.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/component/JiveSortableTable.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/component/JiveTable.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/component/Table.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/ui/ContactList.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceRoomBrowser.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/GroupChatParticipantList.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/ui/status/CustomMessages.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/spark/util/StringUtils.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/sparkimpl/plugin/viewer/PluginRenderer.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/sparkimpl/preference/sounds/SoundPreference.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/sparkimpl/profile/VCardManager.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • core/src/main/java/org/jivesoftware/sparkimpl/search/users/UserSearchForm.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • plugins/reversi/src/main/java/org/jivesoftware/game/reversi/ReversiPanel.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
    • plugins/reversi/src/main/java/org/jivesoftware/game/reversi/ReversiPlugin.java (version caaf9db56fc98526b9e794b93283f320ccc6bb30)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> b7f4fe241a3d8f6e9418a8c000663aee418b9a8b

    SPARK-1469: Code cleanup: Fix probable bugs: Replace group delimiter literals with constant

    • core/src/main/java/org/jivesoftware/spark/ui/ContactList.java (version b7f4fe241a3d8f6e9418a8c000663aee418b9a8b)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> a57aca5e3ecab57126ee3aebfbb37068813a296e

    SPARK-1469: Code cleanup: Fix probable bugs: Copy constructor missed fields

    • core/src/main/java/org/jivesoftware/spark/ui/history/HistoryEntry.java (version a57aca5e3ecab57126ee3aebfbb37068813a296e)
    • core/src/main/java/org/jivesoftware/spark/ui/history/HistoryMessage.java (version a57aca5e3ecab57126ee3aebfbb37068813a296e)
  • arthur <ostretsov_av@hotmail.com>

    arthur <ostretsov_av@hotmail.com> 0594317b79f544b352cb1ec2a590a8e0190e0ccf

    SPARK-1469: Code cleanup: Fix probable bugs: Magic Constants

    • core/src/main/java/org/jivesoftware/spark/component/MessageDialog.java (version 0594317b79f544b352cb1ec2a590a8e0190e0ccf)
    • core/src/main/java/org/jivesoftware/spark/component/TitlePanel.java (version 0594317b79f544b352cb1ec2a590a8e0190e0ccf)
    • core/src/main/java/org/jivesoftware/spark/ui/ChatInputEditor.java (version 0594317b79f544b352cb1ec2a590a8e0190e0ccf)
    • core/src/main/java/org/jivesoftware/spark/ui/ReconnectPanelSmall.java (version 0594317b79f544b352cb1ec2a590a8e0190e0ccf)
    • core/src/main/java/org/jivesoftware/spark/ui/RosterDialog.java (version 0594317b79f544b352cb1ec2a590a8e0190e0ccf)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConversationInvitation.java (version 0594317b79f544b352cb1ec2a590a8e0190e0ccf)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/GroupChatParticipantList.java (version 0594317b79f544b352cb1ec2a590a8e0190e0ccf)