Build #617

Plan branch:
Builds Spark (minus the Install4j distributables) after every change to the code.

Build: #617 was successful Changes by Sergey Ponomarev <stokito@gmail.com>

Stages & jobs

  1. Build Stage

Code commits

Spark (master)

  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 3ff622b7b074781c530072e9f9d79c693276955c

    SPARK-2384: extract UriManager.retrieveParam()

    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version 3ff622b7b074781c530072e9f9d79c693276955c)
    • core/src/test/java/org/jivesoftware/spark/uri/UriManagerTest.java (version 3ff622b7b074781c530072e9f9d79c693276955c)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 81ee81aeb736dd71ae2c47f0aa691443b7b6c155

    refactor: enterRoom() remove muc param because it's used to just get the roomJID that we already have as a param

    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceUtils.java (version 81ee81aeb736dd71ae2c47f0aa691443b7b6c155)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/AgentConversations.java (version 81ee81aeb736dd71ae2c47f0aa691443b7b6c155)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/CurrentActivity.java (version 81ee81aeb736dd71ae2c47f0aa691443b7b6c155)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 75506b1b719d4f9aed55296c4ae5f597dc395929

    ChatManager.handleURIMapping(): reformat

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version 75506b1b719d4f9aed55296c4ae5f597dc395929)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 412036c47f3462a3f3b71c0368b1863dbe291dc6

    SPARK-2384: fix: ChatManager.handleURIMapping(): use Java parsing for xmpp URIs

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version 412036c47f3462a3f3b71c0368b1863dbe291dc6)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 84485b3f468c2238c284de89ed7b1e0c9895bba1

    refactor: InviteSwingWorker use Collection instead of Set for invitees to avoid unnecessary copying

    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceUtils.java (version 84485b3f468c2238c284de89ed7b1e0c9895bba1)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/InvitationDialog.java (version 84485b3f468c2238c284de89ed7b1e0c9895bba1)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/InviteSwingWorker.java (version 84485b3f468c2238c284de89ed7b1e0c9895bba1)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> d0def4cfb4cbabaff79b94be385640a9a22bb211

    fix: UriManager.retrievePassword() decode URL-encoded password value

    • core/src/main/java/org/jivesoftware/spark/ui/ChatArea.java (version d0def4cfb4cbabaff79b94be385640a9a22bb211)
    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version d0def4cfb4cbabaff79b94be385640a9a22bb211)
    • core/src/test/java/org/jivesoftware/spark/uri/UriManagerTest.java (version d0def4cfb4cbabaff79b94be385640a9a22bb211)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 09c8b96f55fddc3917d46ee90d49a163fd39e45b

    refactor: remove unused params nickname and password from ConferenceUtils.enterRoom()
    The nickname will be anyway taken from preferences inside the JoinRoomSwingWorker

    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceServices.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceUtils.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConversationInvitation.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • core/src/main/java/org/jivesoftware/spark/ui/conferences/GroupChatInvitationUI.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/internal/WorkgroupManager.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/Workpane.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/AgentConversations.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/CurrentActivity.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/InvitationPane.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/UserInvitationPane.java (version 09c8b96f55fddc3917d46ee90d49a163fd39e45b)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 5524d85f647518ceba5216c6e50eacfffdd358d6

    Move ChatManager.handleURIMapping() into UriManager and use the UriManager directly

    • core/src/main/java/org/jivesoftware/SparkStartupListener.java (version 5524d85f647518ceba5216c6e50eacfffdd358d6)
    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version 5524d85f647518ceba5216c6e50eacfffdd358d6)
    • core/src/main/java/org/jivesoftware/spark/SparkManager.java (version 5524d85f647518ceba5216c6e50eacfffdd358d6)
    • core/src/main/java/org/jivesoftware/spark/Workspace.java (version 5524d85f647518ceba5216c6e50eacfffdd358d6)
    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version 5524d85f647518ceba5216c6e50eacfffdd358d6)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 4ce0c0ab5c0b21d80eaa47b6faa26223bae94020

    refactor: enterRoom() change tabTitle to the EntityBareJid because it's always the roomJID

    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceUtils.java (version 4ce0c0ab5c0b21d80eaa47b6faa26223bae94020)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 9d77ceb18de915ee40636d12d2596624eca5a320

    ChatManager.handleURIMapping(): simplify UriManager.uritypes enum and use switch statement in the handleURIMapping()

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version 9d77ceb18de915ee40636d12d2596624eca5a320)
    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version 9d77ceb18de915ee40636d12d2596624eca5a320)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> a19774f5a46975f36b060c1568c71dc1880db853

    refactor: ChatManager.handleURIMapping(): check protocol an beginning

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version a19774f5a46975f36b060c1568c71dc1880db853)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> aea7dc1de21a418cf84e355f1f8799ab81bae0bc

    JoinRoomSwingWorker: remove unused constructors

    • core/src/main/java/org/jivesoftware/spark/ui/conferences/JoinRoomSwingWorker.java (version aea7dc1de21a418cf84e355f1f8799ab81bae0bc)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> c85366be944110f66e0faaaa6e70ad307c624bfb

    refactor: replace enterRoom() with enterRoomOnSameThread()

    • core/src/main/java/org/jivesoftware/spark/ui/conferences/ConferenceUtils.java (version c85366be944110f66e0faaaa6e70ad307c624bfb)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/AgentConversations.java (version c85366be944110f66e0faaaa6e70ad307c624bfb)
    • plugins/fastpath/src/main/java/org/jivesoftware/fastpath/workspace/panes/CurrentActivity.java (version c85366be944110f66e0faaaa6e70ad307c624bfb)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> 4a885805ebf8c2f8fb686f669b4ab46c5f8515fb

    refactor: Reformat

    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version 4a885805ebf8c2f8fb686f669b4ab46c5f8515fb)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> b94f5c42ee2a16518e3d151296c692f17e69e758

    SPARK-2384: make UriManager.retrieveJID() to return null and handle it gracefully

    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version b94f5c42ee2a16518e3d151296c692f17e69e758)
    • core/src/test/java/org/jivesoftware/spark/uri/UriManagerTest.java (version b94f5c42ee2a16518e3d151296c692f17e69e758)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> cf27c00191b35f72019a240eaf50ec2f3c12348e

    ChatManager.handleURIMapping(): extract command from query

    • core/src/main/java/org/jivesoftware/spark/ChatManager.java (version cf27c00191b35f72019a240eaf50ec2f3c12348e)
  • Sergey Ponomarev <stokito@gmail.com>

    Sergey Ponomarev <stokito@gmail.com> ec023010a8c2ccb39b5a22770d0603dd6bc40583

    SPARK-2384: allow xmpp:JID as link in chat messages and handle it correctly with the UriManager

    • core/src/main/java/org/jivesoftware/SparkStartupListener.java (version ec023010a8c2ccb39b5a22770d0603dd6bc40583)
    • core/src/main/java/org/jivesoftware/spark/Workspace.java (version ec023010a8c2ccb39b5a22770d0603dd6bc40583)
    • core/src/main/java/org/jivesoftware/spark/ui/ChatArea.java (version ec023010a8c2ccb39b5a22770d0603dd6bc40583)
    • core/src/main/java/org/jivesoftware/spark/ui/MessageEntry.java (version ec023010a8c2ccb39b5a22770d0603dd6bc40583)
    • core/src/main/java/org/jivesoftware/spark/uri/UriManager.java (version ec023010a8c2ccb39b5a22770d0603dd6bc40583)