Spark (master)

• 

  wroot <wrooot@users.noreply.github.com> 03 Aug 2020 094a2f55c3db5dffde87e78595e12a4ee53438db

  Merge pull request #497 from guusdk/OF-2079_Fix-settings-storage-upon-login
  OF-2079: Ensure settings are properly saved upon login
• 

  Guus der Kinderen 03 Aug 2020 3c44e04bbb5747dfc49e9a6bbff2065042c78d94

  SPARK-2079: Ensure settings are properly saved upon login
  The way the 'advanced settings' dialog of the login screen works, causes it to save its configuration to file whenever 'an event' happens.
  
  When saving the configuration, the state of the various UI elements (checkboxes, radiobuttons, etc) is used to update the configuration file.
  
  Eligble events happen more often than expected, for example, when the dialog is disposed (which can occur much later after when it was closed). By that time, the settings of the UI elements can be outdated. This causes an issue where settings are unexpectedly 'reverted'.
  
  This commit works around this problem by only allowing the settings to be updated while the screen is visible.

  • core/src/main/java/org/jivesoftware/spark/ui/login/LoginSettingDialog.java (version 3c44e04bbb5747dfc49e9a6bbff2065042c78d94)
  • core/src/main/java/org/jivesoftware/sparkimpl/settings/local/SettingsManager.java (version 3c44e04bbb5747dfc49e9a6bbff2065042c78d94)
• 

  Guus der Kinderen 03 Aug 2020 74829966e0c89f0b8718113a3b6b81cf8a0a2cd5

  SPARK-2079: Improve adding self-signed certificates upon login.
  This builds on the fix for SPARK-2070: when upon login a certificate is encountered that is self-signed (when this is disallowed by the configuration) prompt the user, and let them try again.

  • core/src/main/java/org/jivesoftware/LoginDialog.java (version 74829966e0c89f0b8718113a3b6b81cf8a0a2cd5)
  • core/src/main/resources/i18n/spark_i18n.properties (version 74829966e0c89f0b8718113a3b6b81cf8a0a2cd5)
  • core/src/main/resources/i18n/spark_i18n_nl.properties (version 74829966e0c89f0b8718113a3b6b81cf8a0a2cd5)
• 

  wroot <wrooot@users.noreply.github.com> 03 Aug 2020 d3f3352c659fed6012d78bfe152ea6099f8e03d4

  Merge pull request #496 from guusdk/SPARK-2110_vcard-new-api
  SPARK-2110: Stop using deprecated VCard API
• 

  wroot <wrooot@users.noreply.github.com> 03 Aug 2020 cc74b72ad486b5f02aa79d9b069c09bbab8b9615

  Merge pull request #495 from guusdk/SPARK-2133_i18n-load
  SPARK-2133: Don't search jar for translations
• 

  wroot <wrooot@users.noreply.github.com> 03 Aug 2020 0c7b1e06cee1692684bdb9487d171849130e5257

  Merge pull request #494 from guusdk/SPARK-2070_automatically_relogin_after_cert_acceptance
  SPARK-2070: Login automatically after accepting server cert
• 

  Guus der Kinderen 03 Aug 2020 925135b424dfc8ff40748b219b3229a437d6daba m

  SPARK-2110: Stop using deprecated VCard API
  Smack has deprecated parts of the VCard API (primarily the 'load' and 'save' methods). As Spark still used this API at some points, some data doesn't get refereshed / loaded properly. By switching to the new API, these problems disappear.

  • core/src/main/java/org/jivesoftware/spark/ui/RosterDialog.java (version 925135b424dfc8ff40748b219b3229a437d6daba)
  • core/src/main/java/org/jivesoftware/sparkimpl/profile/VCardEditor.java (version 925135b424dfc8ff40748b219b3229a437d6daba)
  • core/src/main/java/org/jivesoftware/sparkimpl/profile/VCardManager.java (version 925135b424dfc8ff40748b219b3229a437d6daba)
• 

  Guus der Kinderen 03 Aug 2020 89f16500739f6d73fb678506fd5edf22b21dbd80 m

  SPARK-2133: Don't search jar for translations
  Instead of specifically looking for i18n-files in the spark.jar file, just check if they're anywhere on the classpath. This is more likely to yield results (especially when Spark isn't ran from a jar file, but from an IDE). I'd not be surprised if it's moderately faster too, as no ZIP file operations are needed).

  • core/src/main/java/org/jivesoftware/sparkimpl/plugin/language/LanguagePlugin.java (version 89f16500739f6d73fb678506fd5edf22b21dbd80)
• 

  Guus der Kinderen 03 Aug 2020 27745d9dc5f90fb4eb19f16f31f2d6e174e5f163 m

  SPARK-2070: Login automatically after accepting server cert
  When an authentication attempt fails because of the server presenting a certificate that's not recognized, the end user gets asked to add the certificate.
  
  When the end user chooses to accept the certificate, another authentication attempt should be performed automatically. Up until this commit, that did not occur.
  
  To be able to act based on the choice of the user, the mechanism in which the dialog is shown had to be replaced. This removed some of the more elaborate functionality added by Pawel (that allowed for each intermediate certificate in the chain to be added individually). I've opted to simply add every certificate in the chain.

  • core/src/main/java/org/jivesoftware/LoginDialog.java (version 27745d9dc5f90fb4eb19f16f31f2d6e174e5f163)
  • core/src/main/java/org/jivesoftware/sparkimpl/certificates/CertificateController.java (version 27745d9dc5f90fb4eb19f16f31f2d6e174e5f163)
  • core/src/main/java/org/jivesoftware/sparkimpl/certificates/InBandCertificateChainDialog.java (version 27745d9dc5f90fb4eb19f16f31f2d6e174e5f163)
  • core/src/main/java/org/jivesoftware/sparkimpl/certificates/SparkTrustManager.java (version 27745d9dc5f90fb4eb19f16f31f2d6e174e5f163)
  • core/src/main/java/org/jivesoftware/sparkimpl/certificates/UnrecognizedServerCertificatePanel.java (version 27745d9dc5f90fb4eb19f16f31f2d6e174e5f163)
  • core/src/main/resources/i18n/spark_i18n.properties (version 27745d9dc5f90fb4eb19f16f31f2d6e174e5f163)