Build #251

Plan branch:

Build: #251 was successful Changes by Guus der Kinderen

Code commits

github repo

  • Guus der Kinderen

    Guus der Kinderen 93d1edc17d90957ac1a76a9bfd68f30a2152c66c

    Fix spelling in Javadoc
    Co-authored-by: Dan Caseley <dan@caseley.me.uk>

    • src/main/java/org/jivesoftware/util/PluginVersionComparator.java (version 93d1edc17d90957ac1a76a9bfd68f30a2152c66c)
  • Guus der Kinderen

    Guus der Kinderen e797011135d435530b8a516ae0131ca3691de3d3

    fixes #208: plugin version identifier comparision
    As the website code has to deal with plugin version identifiers that sometimes predate the stricter Maven syntax, it is using a simple alphabetic comparator. This causes problems when comparing numbers that do not have the same amount of digits (eg 10 < 9).

    This commit works around this issue, by zero-padding all values to the same lenght, before applying the alphabetic comparator. This should not affect ordering of the free-format version identifiers to much, while it will ensure that numeric ordering is improved: 10 > 09.

    • src/main/java/org/jivesoftware/site/PluginManager.java (version e797011135d435530b8a516ae0131ca3691de3d3)
    • src/main/java/org/jivesoftware/util/PluginVersionComparator.java (version e797011135d435530b8a516ae0131ca3691de3d3)
    • src/test/java/org/jivesoftware/util/PluginVersionComparatorTest.java (version e797011135d435530b8a516ae0131ca3691de3d3)