Build: #1254 was successful Scheduled with changes by Guus der Kinderen

Stages & jobs

  1. Build and Package

  2. Copy to Website

Build result summary

Details

Completed
Queue duration
13 minutes
Duration
1 minute
Labels
None
Revision
ab2e95c1471edddd304568b043f20f86fbd35ec1
Total tests
476
Successful since
#1125 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen ab2e95c1471edddd304568b043f20f86fbd35ec1 OF-2381: Prevent high-frequency MUC ghost detection pings
When an occupant of a MUC room is inactive, Openfire can send it pings to see if it is still alive.

The existing implementation would generate a ping during each periodic check, after an occupant was inactive, which is to frequent. Subsequent pings should not be sooner than the configured allowed idle time.
Guus der Kinderen Guus der Kinderen 9533c22903b2ead3a3f961ba645b6f7da9703c2f OF-2381: Check for activity before kicking ghost MUC user
MUC Ghost detection uses an IQ Ping to determine if an occupant is a ghost and should be kicked.

Prior to this commit, unanswered Pings always resulted in a kick, which proves to be overzealous:
- if the ping was not answered, but activity since the ping request was detected (eg: the client reconnected), there's no need to kick the occupant.
- if the ping was not answered, but the occupant is no longer connected to the local cluster node, there should be no kick. If the occupant is still connected, then it likely reconnected to another cluster node.
Guus der Kinderen Guus der Kinderen 3e6d3e7737bdb9cecc446c948a61af17966eb518 OF-2381: Cancel pending Ping when MUC occupant disconnects
When a MUC occupant disconnects, a pending ghost detection ping task should be aborted. This reduces the chance that a lingering task incorrectly removes a reconnected occupant.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2381Could not obtain issue details from Jira