Build #1,507

Plan branch:

Build: #1507 failed Scheduled with changes by Dan Caseley <dan@caseley.me.uk> and Guus der Kinderen

Stages & jobs

  1. Build and Package

  2. Copy to Website

Build result summary

Details

Completed
Queue duration
5 minutes
Duration
16 seconds
Labels
None
Revision
bda4ffab4217f76d2c1290650318441399f58e13
Failing since
#1500 (Scheduled with changes by Guus der Kinderen – )
Fixed in
#1513 (Manual run by Guus der Kinderen)
No failed test found. A possible compilation error occurred.

Responsible

  • Guus der Kinderen Guus der Kinderen Automatically assigned

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen bda4ffab4217f76d2c1290650318441399f58e13 OF-2557: Show TLS config on each session/connection
The cipher suite used for encryption is currently exposed (and shown on the admin console) only for S2S sessions, but should be exposed for all session types.

Similarly, lets expose the TLS version that is being used (to complement the cipher suite). This will be useful to diagnose the TLS configuration for each session type.

Implementation-wise, the TLS characteristics should be exposed by Connections, not by Session objects.

Confusingly, Openfire refers to ‘securing’ a connection, which could refer to authentication or encryption. Rename to ‘encrypt’ where appropriate.
Guus der Kinderen Guus der Kinderen 5dbf2a7699e7165177a9f8294b0879648bc5bb7d OF-2556: Record namespace prefixes sent on root XML element
XMPP connections take the form of an XML document, starting with a 'stream' root element.

Openfire processes the direct child elements as if they were individual documents (for reasons beyond the scope of this issue). In that approach, any namespaces defined in the original root element are lost.

Generally, this isn't much of an issue, as a default namespace is assumed/used that is specific to the connection type. However, if the root element defined _other_ issues, that information is lost.

Defining additional namespaces is allowed in XML/XMPP, but isn't typically used. If it were, we would have hit problems long ago. There is one known application of this, which is Dialback (refactoring Openfire's S2S server to use MINA as part of OF-1112 is how this issue was found).

Openfire should be able to XML-parse child elements of the root 'stream' tags, if those child elements use a prefix that refers to a namespace defined on that root element.

This commit achieves that, by recording such declarations in the `Connection` representation over which they were sent. When such declarations are found, each stanza that is processed is wrapped in dummy root element, on which those definitions are placed, prioer to XML parsing. After parsing, the root element is discarded again.
Guus der Kinderen Guus der Kinderen 317e0659aa3be5c50a18ccd44697338e4d37cc41 OF-2556: Add unit tests and rename method
Dan Caseley <dan@caseley.me.uk> Dan Caseley <dan@caseley.me.uk> f44e3858dd13392cb2508fc05486347f57db10cf OF-2510: Complete doc, with resilience test
Guus der Kinderen Guus der Kinderen 7bb976b4df0208e3b9b9647be756679efb871bae OF-2510: DB Clustering Guide minor changes and linked in index

7 more changes...

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-1112Could not obtain issue details from Jira
Unknown Issue TypeOF-2510Could not obtain issue details from Jira
Unknown Issue TypeOF-2556Could not obtain issue details from Jira
Unknown Issue TypeOF-2557Could not obtain issue details from Jira

Error summary for Debian Workflow

The job generated some errors, drill down into the full build log for more details.

Could not find test result reports in the /var/atlassian/bamboo-home/local-working-dir/OPENFIRE-NMDB-JOB1 directory.