Build #1,675

Plan branch:

Build: #1675 was successful Scheduled with changes by 5 people

Stages & jobs

  1. Build and Package

  2. Copy to Website

Code commits

Openfire (master)

  • Matthew Vivian <matthew.vivian@surevine.com>

    Matthew Vivian <matthew.vivian@surevine.com> 3f6b590b66e5e277e6e7bb58a47fe237d17345f3

    OF-2597 Adds config option for wildcards in auth-exclusions
    Adds a new configuration option (SystemProperty<Boolean>) that controls whether wildcards can be used in auth-exclusions. Changes to the property value do not require a restart to become effective. The default value for this property is to disallow wildcard usage.

    Wildcards should not be used when configuration auth-exclusions. They are easily abused.

    It cannot be ruled out that existing versions of third-party code (such as plugins) depend on the ability to use wildcards in auth-exclusions. Wildcards should therefor remain usable - but perhaps not by default.

    • i18n/src/main/resources/openfire_i18n.properties (version 3f6b590b66e5e277e6e7bb58a47fe237d17345f3)
    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 3f6b590b66e5e277e6e7bb58a47fe237d17345f3)
    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version 3f6b590b66e5e277e6e7bb58a47fe237d17345f3)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> 83636b608a31f68a3dc5a746feab65f579c7176a

    OF-2597 typo

    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version 83636b608a31f68a3dc5a746feab65f579c7176a)
  • Alex Gidman <alex.gidman@surevine.com>

    Alex Gidman <alex.gidman@surevine.com> 315a007059c0fa207361b92f76ea5126ea551b77

    chore: OF-2599 - standardise approach to exclude add / remove

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 315a007059c0fa207361b92f76ea5126ea551b77)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> a8feebfb23ba31db342b40e00a9bff6fd2c06f5b

    OF-2597 added check for encoded .. as well as what was alerady there

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version a8feebfb23ba31db342b40e00a9bff6fd2c06f5b)
    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version a8feebfb23ba31db342b40e00a9bff6fd2c06f5b)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> 3cd221f011bb31b7b3ee6c0cbc1a9f3d9c0613d5

    OF-2597 cleanup

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 3cd221f011bb31b7b3ee6c0cbc1a9f3d9c0613d5)
  • Matthew Vivian <matthew.vivian@surevine.com>

    Matthew Vivian <matthew.vivian@surevine.com> 12175ec7bb1bbb441c9da12e79c0a9a1c73aded7

    OF-2597 Rename config option for wildcards in auth-exclusions
    Improves the name used for the system property that controls whether wildcards are allowed in URLs that are excluded from auth checks.

    • i18n/src/main/resources/openfire_i18n.properties (version 12175ec7bb1bbb441c9da12e79c0a9a1c73aded7)
    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 12175ec7bb1bbb441c9da12e79c0a9a1c73aded7)
  • Alex Gidman <alex.gidman@surevine.com>

    Alex Gidman <alex.gidman@surevine.com> 4eccd1727f68089a2b70f3bec873f18e113ff2e4

    fix: OF-2599 - remove setup pages from AuthCheckFilter excludes once setup completed

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 4eccd1727f68089a2b70f3bec873f18e113ff2e4)
  • Alex Gidman <alex.gidman@surevine.com>

    Alex Gidman <alex.gidman@surevine.com> d1fc885e41821b4a76c4873e9ec4e6ad280ce4eb

    fix: OF-2599 - re-initialise the excludes set on AuthCheckFilter destroy

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version d1fc885e41821b4a76c4873e9ec4e6ad280ce4eb)
  • Danny Jackson <danny.jackson@surevine.com>

    Danny Jackson <danny.jackson@surevine.com> 9cf728187fedbf7c6ab0e887a8fdcf36d4c63c2e

    Updates restrictAdminLocalhost to restrict the entire adminconsole network interface rather than just the http auth layer

    • xmppserver/src/main/webapp/setup/setup-host-settings.jsp (version 9cf728187fedbf7c6ab0e887a8fdcf36d4c63c2e)
  • Alex Gidman <alex.gidman@surevine.com>

    Alex Gidman <alex.gidman@surevine.com> dd30f7e60415eb71d04c6676f5748b7890470807

    fix: OF-2599 - switch to load setup excludes programmatically at runtime if in setup mode

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version dd30f7e60415eb71d04c6676f5748b7890470807)
    • xmppserver/src/main/java/org/jivesoftware/openfire/container/AdminConsolePlugin.java (version dd30f7e60415eb71d04c6676f5748b7890470807)
    • xmppserver/src/main/java/org/jivesoftware/util/JiveGlobals.java (version dd30f7e60415eb71d04c6676f5748b7890470807)
    • xmppserver/src/main/webapp/WEB-INF/web.xml (version dd30f7e60415eb71d04c6676f5748b7890470807)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> c8f646b505fd3c317a188007cc8a63db667dafb1

    OF-2597 simplifying

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version c8f646b505fd3c317a188007cc8a63db667dafb1)
    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version c8f646b505fd3c317a188007cc8a63db667dafb1)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> ef05cf4d8c9597042fc298981896e8d62df31138

    OF-2597 checks for valid UTF-8 encoding of URL if fails then wont redirect

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version ef05cf4d8c9597042fc298981896e8d62df31138)
    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version ef05cf4d8c9597042fc298981896e8d62df31138)
  • Danny Jackson <danny.jackson@surevine.com>

    Danny Jackson <danny.jackson@surevine.com> 8618aa84a55924daf9d52c520c4667c448f999a9

    Shifts order of settings being applied for better readability.

    • xmppserver/src/main/webapp/setup/setup-host-settings.jsp (version 8618aa84a55924daf9d52c520c4667c448f999a9)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> b39cf96e8c5fa2f3be2733ecbeca8a931232ea6c

    OF-2597 omits UTF-16 encoded dots

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version b39cf96e8c5fa2f3be2733ecbeca8a931232ea6c)
    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version b39cf96e8c5fa2f3be2733ecbeca8a931232ea6c)
  • Danny Jackson <danny.jackson@surevine.com>

    Danny Jackson <danny.jackson@surevine.com> b6dcbe820a3c709fff456face13b4af379407c04

    OF-2598 - Removes wildcard for AuthCheckFilter and replaces with list of setup pages

    • xmppserver/src/main/webapp/WEB-INF/web.xml (version b6dcbe820a3c709fff456face13b4af379407c04)
    • xmppserver/src/test/java/org/jivesoftware/util/WebXmlUtilsTest.java (version b6dcbe820a3c709fff456face13b4af379407c04)
    • xmppserver/src/test/resources/org/jivesoftware/util/test-web.xml (version b6dcbe820a3c709fff456face13b4af379407c04)
  • Alex Gidman <alex.gidman@surevine.com>

    Alex Gidman <alex.gidman@surevine.com> 0f9d5698e69d2dfb9a921f22c53a7e82e281e1bd

    fix: OF-2599 - remove explicit setup paths from AuthCheckFilter excludes once setup has been completed

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 0f9d5698e69d2dfb9a921f22c53a7e82e281e1bd)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> 7141bf7fb973888e9ad7501d7170ad93f60ba7e5

    cleanup

    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version 7141bf7fb973888e9ad7501d7170ad93f60ba7e5)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> 0a4d1ffcfa9624fb5894526f696c18346beadc8b

    OF-2597 simplifying

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 0a4d1ffcfa9624fb5894526f696c18346beadc8b)
  • Brent Slater <brent.slater@surevine.com>

    Brent Slater <brent.slater@surevine.com> 133e751ed6491dd3b3831ec457c5649efd2775c0

    OF-2597 cleanup

    • xmppserver/src/main/java/org/jivesoftware/admin/AuthCheckFilter.java (version 133e751ed6491dd3b3831ec457c5649efd2775c0)
  • Danny Jackson <danny.jackson@surevine.com>

    Danny Jackson <danny.jackson@surevine.com> 462e0cbb6cc29c1dc17d1914172db4fc1a09c6d3

    OF-2604 Bind Admin console to loopback interface
    Defaults to bind to local connections only, however this is toggle-able
    in setup.

    • i18n/src/main/resources/openfire_i18n.properties (version 462e0cbb6cc29c1dc17d1914172db4fc1a09c6d3)
    • xmppserver/src/main/webapp/setup/setup-host-settings.jsp (version 462e0cbb6cc29c1dc17d1914172db4fc1a09c6d3)
  • Guus der Kinderen

    Guus der Kinderen 66b91f7ed30811f4a7eb6d0e13805ee623fe64c2

    OF-2597: Adjust unit test for new property

    • xmppserver/src/test/java/org/jivesoftware/admin/AuthCheckFilterTest.java (version 66b91f7ed30811f4a7eb6d0e13805ee623fe64c2)