Build: #1869 was successful Scheduled with changes by daryl herzmann <akrherz@iastate.edu> and Guus der Kinderen

Stages & jobs

  1. Build and Package

  2. Copy to Website

Build result summary

Details

Completed
Queue duration
22 minutes
Duration
39 minutes
Labels
None
Revision
90f2665e83fa0a9423e04ff938a8e68746000424
Total tests
1385
Successful since
#1859 ()

Tests

Code commits

Author Commit Message Commit date
daryl herzmann <akrherz@iastate.edu> daryl herzmann <akrherz@iastate.edu> 90f2665e83fa0a9423e04ff938a8e68746000424 Merge pull request #2362 from guusdk/OF-2752_StreamManagement-try-to-send-data-on-expected-network-disconnect
OF-2752: Refactor solution
Guus der Kinderen Guus der Kinderen d01f83d0935100e91550de4658b2c0062b1fc9c0 OF-2752: Refactor solution
In the previous commit for this issue, it was assumed that the state of a connection was always known 'good' or 'terminated'. In reality, there are lenghty periods in which Openfire cannot be sure of a connection is terminated, or simply unresponsive.

To avoid clients being disconnected by Openfire without their knowledge, Openfire should always try to send an end-of-stream indication. Without this, clients might assume for indefinite amounts of time that they're connected, while they are not.
Guus der Kinderen Guus der Kinderen a10ffadd1c6d6cc11f7e9ad9e83051bf4fe7c700 OF-2752: Sessions should be resumable only if closed due to 'unclean' disconnect
Prior to this commit, a session was (stream management) resumable whenever it got closed.

When a session is closed 'cleanly' (eg, with an exchange of `</stream>`), then a session should never be resumed.

This commit attempts to reverse the strategy. It is implied that a session is never resumable, unless it is closed unexpectedly (for example, as caused by a network disconnect).

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2752Could not obtain issue details from Jira