Build: #1895 was successful Scheduled with changes by jqgsninimo <jqgsninimo@hotmail.com> and dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Code commits
Openfire (master)
-
jqgsninimo <jqgsninimo@hotmail.com> 7d0972625992a6e302d6460900718ef9a90e702b
Modify the method for determining JRE version
Previously, the method assumed that the format of the JRE version is: major.minor.build.
However, for `openjdk 21`, the value of `System.getProperty("java.version")` is `21`.
This caused the previous method of determination to fail, resulting in the following error message:
> Error: Can not proceed with Openfire Setup.
Your current installation fails to meet minimum server requirements - please see the checklist below:
✗ At least JRE 11
✓ Servlet 2.3 Support
✓ JSP 1.2 Support
✓ Openfire Classes
✓ Openfire Home found (/usr/local/openfire)
Therefore, the method was modified to extract the significant digits using the regular expression `^\d+(\.\d+)?` for version comparison.
The modified method for determination was tested in the following environments:
| JRE Version | 21 | 17.0.1 | 11.0.4 | 10.0.1 | 9.0.1 | 1.8.0_66 |
|---|---|---|---|---|---|---|
| matcher.group(0) | 21 | 17.0 | 11.0 | 10.0 | 9.0 | 1.8 |
| jreVersionCompatible | true | true | true | false | false | false |- xmppserver/src/main/webapp/setup/index.jsp (version 7d0972625992a6e302d6460900718ef9a90e702b)
-
jqgsninimo <jqgsninimo@hotmail.com> 0bc65828f295b56db3f9d4499401711fabcafab9
Enhance JRE Version Determination Method by Extracting Only the Major Version for Comparison.
- xmppserver/src/main/webapp/setup/index.jsp (version 0bc65828f295b56db3f9d4499401711fabcafab9)
-
jqgsninimo <jqgsninimo@hotmail.com> f3566d1d869cbf6eff4aaa429f988e6156daa503
Fixing the redefinition error of `jreVersionCompatible`
Should have used the outer variable `jreVersionCompatible`, but mistakenly defined a new one inside the try block.
Correcting the mistake.- xmppserver/src/main/webapp/setup/index.jsp (version f3566d1d869cbf6eff4aaa429f988e6156daa503)
-
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> 4e13f677dba0a8f7ba6afecb946e154e9cde4850
Bump github/codeql-action from 2 to 3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2...v3)
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>- .github/workflows/codeql-analysis.yml (version 4e13f677dba0a8f7ba6afecb946e154e9cde4850)