Build: #2336 was successful Scheduled with changes by 3 people

Stages & jobs

  1. Build and Package

  2. Copy to Website

Build result summary

Details

Completed
Queue duration
1 second
Duration
14 minutes
Labels
None
Revision
a4decb1af0c39f6126d4f3798380d85d6ab63ffa
Total tests
1742
Successful since
#2296 ()

Tests

Code commits

Author Commit Message Commit date
daryl herzmann daryl herzmann a4decb1af0c39f6126d4f3798380d85d6ab63ffa Merge pull request #2695 from guusdk/OF-3028_Netty-thread-config
OF-3028: Netty threads from 'child' EventLoop should use Netty-default settings
Guus der Kinderen Guus der Kinderen 6d0de547f5feb4ed36d3d6e1cee2c0e8b76de6a6 OF-3028: Netty threads from 'child' EventLoop should use Netty-default settings
As we're overriding the thread factories used for Netty EventLoops to change the names of threads, we've also changed the default configuration of threads used by Netty.

Netty's default configuration can be expected to be optimized for performance. Openfire should use a similar configuration.

In this commit, the configuration is reverted back to the default configuration that's used by Netty (based on `io.netty.util.concurrent.DefaultThreadFactory`).
daryl herzmann daryl herzmann a3c6f662594affb2663fd93a2cc0cc6db34f0cb4 Merge pull request #2694 from guusdk/OF-3027_Netty-parent-eventloop-threadnames
OF-3027: Give Netty threads a recognizable name
Guus der Kinderen Guus der Kinderen 0d4a8ceb24b3bd19c512fcccb18451328f43d223 OF-3027: Give Netty threads a recognizable name
To facilitate debugging, the various threads used by Netty EventLoops should have names that at least contain the type of connection that they're operating for.

This commit changes the name of threads of the
- 'parent' eventloop from `nioEventLoopGroup-7-1` (a Netty default) to `socket_s2s_ssl-acceptor-7`
- 'child' eventloop from `socket_s2s_ssl-thread-3` (a Netty default) to `socket_s2s_ssl-worker-3`

To do this, a new theadpool factory is introduces for the 'parent' eventloop. The new factory is configured to use the same priorty and daemon settings as the default Netty threadpool factory.
Guus der Kinderen Guus der Kinderen c6c9ce751899dc921ace283a0188840f9792c9b7 OF-2966: BOSH events should execute in-order
BOSH related events (mostly: processing of received stanzas) are executed by a worker pool of threads.

Events for each individual session must be processed in the same order in which they are received. Prior to this change, every event was potentially executed by a different worker thread. This can cause some events to be processed (or finish processing) before an earlier event finishes execution in another worker thread.

This commit adds FIFO-based queuing of events, that ensures that events that belong to the same session are processed:
- by only one thread from the worker pool;
- in the same order in which they're received.

The technique applied here is inspired (well, just bluntly copied) from Ben Manes' work in https://github.com/ben-manes/caffeine/blob/master/jcache/src/main/java/com/github/benmanes/caffeine/jcache/event/EventDispatcher.java

Jira issues

IssueDescriptionStatus
7 more issues…
Unknown Issue TypeENT-425Could not obtain issue details from Jira
Unknown Issue TypeOF-2966Could not obtain issue details from Jira
Unknown Issue TypeOF-2967Could not obtain issue details from Jira
Unknown Issue TypeOF-2973Could not obtain issue details from Jira
Unknown Issue TypeOF-2974Could not obtain issue details from Jira

Shared artifacts

Artifact File size
.deb files 55 MB