Build: #2745 was successful Scheduled with changes by 4 people

Stages & jobs

  1. Build and Package

  2. Copy to Website

Build result summary

Details

Completed
Queue duration
4 seconds
Duration
12 minutes
Labels
None
Revision
f1b3780d127f01d73eea68225b236661e47176e2
Total tests
1714
Successful since
#2725 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen b13400071eb5fdbb84afe7e2b0b3946d8fd4116b OF-3262: Improve unit test coverage (more off-by-one checks)
Also refactored some of the existing tests for robustness/consistency.
Guus der Kinderen Guus der Kinderen 0e6053a10645f8769e1e52e292b388247cf95345 OF-3262 (code review) Do not unlock IP-only gate based on username success
Do not let a successful login from one IP also reduce the shared IP-only counter for other IPs that this user previously used. That weakens the secondary per-IP gate.
Guus der Kinderen Guus der Kinderen efa090634a0b0c6934c4957d47a713db7c0a9869 OF-3262: Failed login tracking to use IP/Username combination
This improves failed-login tracking in the admin console by using a combination of username and IP address instead of relying solely on IP-based tracking alone. This primarily fixes an issue where a single user, behind a reverse proxy or NAT, can lock out all other users.

The old IP-only restriction is still left in place. Its default maximum attempts has been increased to a number higher than the IP/Username combination attempt maximum.
Guus der Kinderen Guus der Kinderen f1b3780d127f01d73eea68225b236661e47176e2 fixes small typo
Guus der Kinderen Guus der Kinderen 46b4888c393cca228616a5fccd5cc9de0c788ffd OF-3262 (code review): Improve unit test coverage for LoginLimitManager
This refactors the unit tests, adding explicit coverage for checking single gates.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2970Could not obtain issue details from Jira
Unknown Issue TypeOF-3262Could not obtain issue details from Jira
Unknown Issue TypeOF-3264Could not obtain issue details from Jira
Unknown Issue TypeOF-3271Could not obtain issue details from Jira
Unknown Issue TypeOF-3274Could not obtain issue details from Jira

Shared artifacts

Artifact File size
.deb files 68 MB