Build: #332 was successful Scheduled with changes by daryl herzmann <akrherz@iastate.edu>

Code commits

Openfire (master)

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 4d0c534d63085cef62d15812284c6f5fc6682da0

    Merge pull request #1400 from guusdk/OF-1799_JID-cache-configuration
    OF-1799: Allow JID caches to be configurable

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 024d0437768dd5fc9b41c4c7fddc702888bd42cc

    Merge pull request #1398 from guusdk/OF-1801_Cacche-ineffectiveness-highligh
    OF-1801: Cache low effectivity should be shown more prominent

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 8246de03265d3ef67af2efce177ae9f7b9bfc045

    Merge pull request #1397 from guusdk/OF-1800_Cache_ineffectiveness-calculation
    OF-1800: Cache low effectivity calculation improvement

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 3c858634f5ff7c8c01f49fed21417ac4c1d37cd0

    Merge pull request #1394 from abe-ta/fix/loading-mucrooms-too-slow
    OF-1797 Accelerate loading MUC rooms

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 360e03ce0626292f517a390cca06edf8b5bd7165

    Merge pull request #1399 from guusdk/OF-1802_IQBind-error
    OF-1802: Fix IQ error when using invalid resource during bind.

  • abe.ta <abe.ta@wingarc.com>

    abe.ta <abe.ta@wingarc.com> 693e7170c1b1bc96c117b009927581fe48cac782 m

    Improve loading MUCServiceProperties

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version 693e7170c1b1bc96c117b009927581fe48cac782)
  • Guus der Kinderen

    Guus der Kinderen be74d52ea4a2a3518f0e98e79c4c1999f9b71a84 m

    Make Travis skip javadoc linting.

    • pom.xml (version be74d52ea4a2a3518f0e98e79c4c1999f9b71a84)
  • Guus der Kinderen

    Guus der Kinderen 6d4095528d62f360d63889d3d6028bcb0b016662 m

    OF-1799: Allow JID caches to be configurable
    The JID class uses three caches, in which the result of stringprepping is stored. The capacity of these caches is hardcoded.

    For high-volume instances of Openfire, the hardcoded values might not suffice. It should be possible to reconfigure the caches. Additionally, it would be nice if the caches are displayed in the cache summary admin console page.

    This commit pulls in a new version of the Tinder dependency, that is as of yet unreleased (I'm using a SNAPSHOT version here). Before we release Openfire with this change, this dependency must be replaced with a proper, non-SNAPSHOT release.

    • xmppserver/pom.xml (version 6d4095528d62f360d63889d3d6028bcb0b016662)
    • xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQBindHandler.java (version 6d4095528d62f360d63889d3d6028bcb0b016662)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/CacheFactory.java (version 6d4095528d62f360d63889d3d6028bcb0b016662)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/CaffeineCache.java (version 6d4095528d62f360d63889d3d6028bcb0b016662)
  • Guus der Kinderen

    Guus der Kinderen 9e993bc3b2e8ec6ea8b912fa1e36ebf1fe3e501f m

    OF-1802: Fix IQ error when using invalid resource during bind.
    The missing 'catch' statement caused the exception to be handled by the caller class, which applies a generic error.

    • xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQBindHandler.java (version 9e993bc3b2e8ec6ea8b912fa1e36ebf1fe3e501f)
  • Guus der Kinderen

    Guus der Kinderen 16361efc792d63ee96f68152dc3423b772a2326c m

    OF-1801: Cache low effectivity should be shown more prominent
    This improves the visibility of ineffective cache usage in the admin console.

    • xmppserver/src/main/webapp/system-cache.jsp (version 16361efc792d63ee96f68152dc3423b772a2326c)
  • Guus der Kinderen

    Guus der Kinderen b101a02f953f901a33a17d0b0b49a96356bd6aef m

    OF-1800: Cache low effectivity calculation improvement Openfire uses various caches. The admin console displays a warning when the cache isn't very effective (hinting that reconfiguration is needed.
    The current formula to determine if a cache is ineffective, combines these three parts (which all must be true):
    - amount of successful cache lookups is more than 500
    - percentage of successful cache lookups is less than 85%
    - the amount of unused capacity in the case is 20% or less

    The first condition is likely introduced with the intention to avoid having caches marked as 'ineffective' when they're hardly used (or when the system just started). However, this causes the cache to _not_ be marked 'ineffective' in a scenario where it has many, many lookups, but none of them successful (which clearly is an ineffective cache).

    The first part of the formula should be based on _all_ lookups, not just on the successful ones.

    • xmppserver/src/main/webapp/system-cache.jsp (version b101a02f953f901a33a17d0b0b49a96356bd6aef)
  • abe.ta <abe.ta@wingarc.com>

    abe.ta <abe.ta@wingarc.com> 78224274617e5f3337092bcd2fda6fff696a904f m

    Accelerate loading MUC rooms

    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (version 78224274617e5f3337092bcd2fda6fff696a904f)