Build: #47 was successful Scheduled with changes by daryl herzmann <akrherz@iastate.edu> and Guus der Kinderen

Build result summary

Details

Completed
Queue duration
1 second
Duration
2 minutes
Labels
None
Revision
62618bdde57e3403ddbdcae61c2611fb70a38a62
Total tests
248
Successful since
#33 ()

Tests

Code commits

Author Commit Message Commit date
daryl herzmann <akrherz@iastate.edu> daryl herzmann <akrherz@iastate.edu> 62618bdde57e3403ddbdcae61c2611fb70a38a62 Merge pull request #1155 from guusdk/OF-1596_properly_close_websockets
OF-1596: Allow connections to properly close
daryl herzmann <akrherz@iastate.edu> daryl herzmann <akrherz@iastate.edu> 55f2e6ae78ad53cca24c71599ee8eb86cd28efe0 Merge pull request #1156 from guusdk/OF-1597_inverse-4.0.0
OF-1597: Update inVerse plugin to version 4.0.0
Guus der Kinderen Guus der Kinderen 95525f5b494541d29abae60e637d284514267323 OF-1597: Update inVerse plugin to version 4.0.0
This replaces the converse.js library that's the base of the inVerse plugin to version 4.0.0.
Guus der Kinderen Guus der Kinderen 1ea41476118f527eb370d2bddad2f53cc1c52ed9 OF-1596: Allow connections to properly close
The notification will trigger some shutdown procedures that, amongst other things,
check what type of session (eg: anonymous) is being closed. This check depends on the
session still being available.

For that reason, it's important to first notify the listeners, and then close the
session - not the other way around.

This fixes a very visible bug where MUC users would remain in the MUC room long after
their session was closed. Effectively, the bug prevents the MUC room from getting a
presence update to notify it that the user logged off.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-1596Could not obtain issue details from Jira
Unknown Issue TypeOF-1597Could not obtain issue details from Jira