Build: #381 was successful
Job: Debian Workflow was successful
Code commits
Openfire (master)
-
daryl herzmann <akrherz@iastate.edu> 6bd1d231aae262f9e7a17d9a3482617fb7f2651a
Merge pull request #1435 from guusdk/OF-1826_Dataforms-NPE
OF-1826: Prevent NPE in new DataForms implementation. -
Guus der Kinderen 393517209f711a831832552cb2338d6bad764a0d m
OF-1826: Prevent NPE in new DataForms implementation.
The implementation introduced by OF-1809 causes collections of DataForm instances to be processed.
The new contract defines that a set must be present - null values are not allowed.
It's easy to overlook this new contract. For example, our own code returned a null value, instead of an empty collection.
This commit modifies the return of a null value (it now returns an empty value). Additionally, this PR adds a guard for problems like this, by explicitly checking of a value is null.- xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandler.java (version 393517209f711a831832552cb2338d6bad764a0d)