Build: #1134 failed Scheduled with changes by Dan Caseley <dan@caseley.me.uk> and Guus der Kinderen

Code commits

Openfire (master)

  • Guus der Kinderen

    Guus der Kinderen f4c5d924d2a4a8df78c6ea6643a327136125994e

    OF-2398: Admin console: add visual indication of MUC room being locked
    MUC rooms can be 'locked', which typically occurs when they are initially being created and configured. When a MUC room is 'locked', it cannot be entered by users.

    The Openfire admin console should make it possible for an administrator to see if a room is locked.

    This commit replaces the value in the 'users' column on the room summary page with a 'lock' icon, and displays a warning on the room settings page, when the room is locked.

    • i18n/src/main/resources/openfire_i18n.properties (version f4c5d924d2a4a8df78c6ea6643a327136125994e)
    • i18n/src/main/resources/openfire_i18n_nl.properties (version f4c5d924d2a4a8df78c6ea6643a327136125994e)
    • xmppserver/src/main/webapp/muc-room-edit-form.jsp (version f4c5d924d2a4a8df78c6ea6643a327136125994e)
    • xmppserver/src/main/webapp/muc-room-summary.jsp (version f4c5d924d2a4a8df78c6ea6643a327136125994e)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 8b3b9914a4e624f0d7f56697a72284fcd24deb1f

    OF-2383: Protect from groups being created with duplicate names

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version 8b3b9914a4e624f0d7f56697a72284fcd24deb1f)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 8b3b9914a4e624f0d7f56697a72284fcd24deb1f)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 3f79e346c0f6ca381c90a6b40206566dd10a7309

    OF-2383: Protect from group name changes with invalid names
    Blank names, changing from a non-existent group, changing to an already-existent group

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version 3f79e346c0f6ca381c90a6b40206566dd10a7309)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version 3f79e346c0f6ca381c90a6b40206566dd10a7309)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/Group.java (version 3f79e346c0f6ca381c90a6b40206566dd10a7309)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupProvider.java (version 3f79e346c0f6ca381c90a6b40206566dd10a7309)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 3f79e346c0f6ca381c90a6b40206566dd10a7309)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerTest.java (version 3f79e346c0f6ca381c90a6b40206566dd10a7309)
  • Guus der Kinderen

    Guus der Kinderen e74fcaacf5b78cc06439552780fb445feb7932d3

    DBUnit implies JUnit 3
    The way that this test class uses DBUnit inherits a JUnit 3 style of testcase setup. This means that test annotations (as provided by JUnit 4) are not used/ignored. This commit removes those annotations, to avoid confusion.

    Additionally, static fields from GroupProvider are cleaned up after test execution, to avoid their values leaking to other test classes.

    • xmppserver/src/main/java/org/jivesoftware/openfire/crowd/CrowdGroupProvider.java (version e74fcaacf5b78cc06439552780fb445feb7932d3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version e74fcaacf5b78cc06439552780fb445feb7932d3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupManager.java (version e74fcaacf5b78cc06439552780fb445feb7932d3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/JDBCGroupProvider.java (version e74fcaacf5b78cc06439552780fb445feb7932d3)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version e74fcaacf5b78cc06439552780fb445feb7932d3)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version e74fcaacf5b78cc06439552780fb445feb7932d3)
  • Guus der Kinderen

    Guus der Kinderen 319883129fe9dc019e4625cb49b81adf423b1122

    Group Sharing: rework caching
    Warning: this introduces a potential breaking change to proprietary sub-classes of AbstractGroupProvider that are _not_ read-only (if anyone that maintains such an implementation and reads this, get in contact and I'll buy you a beer). After this commit, these implementations should explicitly call the 'super' methods that they override, to ensure that the cache of shared groups remains consistent. The changes that are needed are similar to the changes that are applied in this commit to DefaultGroupProvider.

    Maintenance of the cache in which metadata related to group sharing is stored is now managed 'directly', rather than as dependent on an event listener.

    Cache maintenance as implemented in this commit is very simple: on any change, the the entire cache is cleared. This can probably be improved on, but that will increase complexity, which increases the risk of bugs. As changes to groups are expected to be infrequent, the blunt 'clear all' is expected to be a acceptable trade-off.

    Additional unit tests have been added to verify the behavior of caches. Specifically, these new tests try to warm up a cache, then apply a change to state that is expected to be cached, then retrieves the entity that's expected to was cached again. The test then asserts that the change is visible.

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version 319883129fe9dc019e4625cb49b81adf423b1122)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupPropertyMap.java (version 319883129fe9dc019e4625cb49b81adf423b1122)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version 319883129fe9dc019e4625cb49b81adf423b1122)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 319883129fe9dc019e4625cb49b81adf423b1122)
  • Guus der Kinderen

    Guus der Kinderen 38806b5e5f49765ed3170f82cbf77b64aa722a9d

    Improve isolation of test classes
    Tests that use GroupProvider should ensure that its static fields are reset after use. This avoids their values to be used by other classes that use GroupProvider.

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerTest.java (version 38806b5e5f49765ed3170f82cbf77b64aa722a9d)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> c74c4d5c985ed236d03e781ecc9151006ec6e71b

    OF-2383: Add tests for searching groups

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version c74c4d5c985ed236d03e781ecc9151006ec6e71b)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> fb3ef5bc512e0df07a9e6b4e6b8771ec6f003452

    OF-2383: Protect against updating membership of a non-existent group

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version fb3ef5bc512e0df07a9e6b4e6b8771ec6f003452)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version fb3ef5bc512e0df07a9e6b4e6b8771ec6f003452)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/Group.java (version fb3ef5bc512e0df07a9e6b4e6b8771ec6f003452)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupProvider.java (version fb3ef5bc512e0df07a9e6b4e6b8771ec6f003452)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version fb3ef5bc512e0df07a9e6b4e6b8771ec6f003452)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerTest.java (version fb3ef5bc512e0df07a9e6b4e6b8771ec6f003452)
  • Guus der Kinderen

    Guus der Kinderen cfa3f5bf062047aeeac070b7427e9ecccba00b13

    Shared groups: onlyGroup and recursion
    When shared groups are configured to be shared with (users in) other groups, the corresponding value for the 'sharedRoster.showInRoster' property is 'onlyGroup'.

    This property value has one of two meanings:
    - the shared group is shared with (users in) the group itself
    - the shared group is shared with (users in) a list of groups (potentially including itself).

    A second property 'sharedRoster.groupList' is used to distinguish between the two: when its value is empty, then the shared group is shared with itself, otherwise, it's shared with the comma-separated list that is the value.

    This commit more clearly defines this distinction, by changing the behavior of org.jivesoftware.openfire.group.AbstractGroupProvider#getVisibleGroupNames(java.lang.String) to return 'the group itself' when the property values indicate this behaviour.

    When sharing groups with groups that themselves are shared with other groups, there's a chance for recursion to be desirable. Example:
    - Users in SharedGroupA are visible to users of SharedGroupB
    - Users in SharedGroupB are visible to users of SharedGroupC
    With recursion disabled, users in SharedGroupC would see only the users of SharedGroupB.
    With recursion enabled, users in SharedGroupC would see users of both SharedGroupA and SharedGroupB.

    This commit adds a new property, abstractGroupProvider.shared.recursive, that controls this behavior.

    • i18n/src/main/resources/openfire_i18n.properties (version cfa3f5bf062047aeeac070b7427e9ecccba00b13)
    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/group/GetListGroups.java (version cfa3f5bf062047aeeac070b7427e9ecccba00b13)
    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/group/UpdateGroup.java (version cfa3f5bf062047aeeac070b7427e9ecccba00b13)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version cfa3f5bf062047aeeac070b7427e9ecccba00b13)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/Group.java (version cfa3f5bf062047aeeac070b7427e9ecccba00b13)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupManager.java (version cfa3f5bf062047aeeac070b7427e9ecccba00b13)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version cfa3f5bf062047aeeac070b7427e9ecccba00b13)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 8da6c42d7e0580c54da4d9b7be1577d3172b9ee1

    OF-2383: Fix license header

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupNameInvalidException.java (version 8da6c42d7e0580c54da4d9b7be1577d3172b9ee1)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> dee225a44551d993bbe1be619271ad20c95a3b69

    OF-2383: Protect from groups being created with empty names

    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/group/AddGroup.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupManager.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupNameInvalidException.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupProvider.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerTest.java (version dee225a44551d993bbe1be619271ad20c95a3b69)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> a4aeacfdec449f19bb3e83ca6210ade5b3959b30

    OF-2383: Move tests of the AbstractGroupProvider to its own test class, and expand

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version a4aeacfdec449f19bb3e83ca6210ade5b3959b30)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/AbstractGroupProviderTest.java (version a4aeacfdec449f19bb3e83ca6210ade5b3959b30)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version a4aeacfdec449f19bb3e83ca6210ade5b3959b30)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 9129a194ec74b0dc5c989b5ae147d98e78c92e26

    OF-2383: Assert static flags on the DefaultGroupProvider

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 9129a194ec74b0dc5c989b5ae147d98e78c92e26)
  • Guus der Kinderen

    Guus der Kinderen ad48a38fba2834dec96d0bccf53c2c02bbea9755

    OF-2389: Reduce overhead of checking for non-existing shared groups
    By caching the fact that there are no shared groups in the database, lookups for very specific shared groups can be short-cirquited. This improves performance in scenarios where no shared groups exist.

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version ad48a38fba2834dec96d0bccf53c2c02bbea9755)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 5a2b82f7397be6c8ed9052394b1b832c438d5225

    OF-2383: Protect against adding a member to a non-existent group

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version 5a2b82f7397be6c8ed9052394b1b832c438d5225)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version 5a2b82f7397be6c8ed9052394b1b832c438d5225)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/Group.java (version 5a2b82f7397be6c8ed9052394b1b832c438d5225)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupProvider.java (version 5a2b82f7397be6c8ed9052394b1b832c438d5225)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 5a2b82f7397be6c8ed9052394b1b832c438d5225)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerTest.java (version 5a2b82f7397be6c8ed9052394b1b832c438d5225)
  • Guus der Kinderen

    Guus der Kinderen d6a5ac7e017a21e767f1591b14f1f6e4bad769cd

    Add cache config for new Shared Group cache

    • xmppserver/src/main/java/org/jivesoftware/util/cache/CacheFactory.java (version d6a5ac7e017a21e767f1591b14f1f6e4bad769cd)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 9bb03ddfa9220e5f5c50c1f6e205ec75cb641480

    OF-2383: Additional check for setting group description

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 9bb03ddfa9220e5f5c50c1f6e205ec75cb641480)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 4ec1f4bc1879f1bc888efcadcf9d82e720496457

    Fix tests that should never have worked, but we've fixed that now :)

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 4ec1f4bc1879f1bc888efcadcf9d82e720496457)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 9ab5ecaa7b5323f83e4714cfc68fae39e35ab855

    OF-2383: Tidy imports

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 9ab5ecaa7b5323f83e4714cfc68fae39e35ab855)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> c70ba9b68262ccbf2e982beb78260a543151b300

    OF-2383: Ensure no errors deleting group memberships that don't exist

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version c70ba9b68262ccbf2e982beb78260a543151b300)
  • Guus der Kinderen

    Guus der Kinderen 1157bb4e039229e244e202b003a5e5fea16a9ea2

    Adjust unit test to make use of new API
    Instead of modifying group properties directly, use new API when configuring contact list sharing.

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 1157bb4e039229e244e202b003a5e5fea16a9ea2)
  • Guus der Kinderen

    Guus der Kinderen 927532cc5af9e4aca65db939a5789185e78b0234

    OF-2385: Do not load shared groups when they're not supported
    Group providers define if they support group sharing. If this is not supported, Openfire's GroupManager should not attempt to load shared groups.

    All providers that ship with Openfire do support this feature. This change would only benefit future or third party providers.

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupManager.java (version 927532cc5af9e4aca65db939a5789185e78b0234)
  • Guus der Kinderen

    Guus der Kinderen 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9

    OF-2382: Do not return all groups when searching for shared groups for a specific user
    `AbstractGroupProvider.getSharedGroupNames(JID)` returns _all_ groups, instead of the groups that are shared with the provided user.

    This commit fixes that problem, and introduces a set of unit tests that verify the behavior.

    • xmppserver/pom.xml (version 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9)
    • xmppserver/src/test/resources/datasets/clean.xml (version 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9)
    • xmppserver/src/test/resources/datasets/dataset.dtd (version 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9)
    • xmppserver/src/test/resources/datasets/openfire.properties (version 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9)
    • xmppserver/src/test/resources/datasets/openfire.script (version 3efe1e7a2c2478c46ab27e3836c0fcf1b5bbb5e9)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> c0dd5f4b71c84159e8c5faf141dcb6cba04db9d0

    OF-2383: Prevent adding full JIDs of remote users to groups

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version c0dd5f4b71c84159e8c5faf141dcb6cba04db9d0)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version c0dd5f4b71c84159e8c5faf141dcb6cba04db9d0)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> cddfb506346b7b5bf3d808c6e1773a088842e3ec

    OF-2383: Explicitly fail tests rather than bomb out with exceptions

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version cddfb506346b7b5bf3d808c6e1773a088842e3ec)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 2a272a4635da05145262407f01ad4dfd6c0f6469

    OF-2383: Add missing test descriptions

    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 2a272a4635da05145262407f01ad4dfd6c0f6469)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 438609ece689c93f3ffd47428f2063daadbf5539

    OF-2383: Trap when deleting non-existent groups

    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/group/DeleteGroup.java (version 438609ece689c93f3ffd47428f2063daadbf5539)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/AbstractGroupProvider.java (version 438609ece689c93f3ffd47428f2063daadbf5539)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version 438609ece689c93f3ffd47428f2063daadbf5539)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupManager.java (version 438609ece689c93f3ffd47428f2063daadbf5539)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupProvider.java (version 438609ece689c93f3ffd47428f2063daadbf5539)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 438609ece689c93f3ffd47428f2063daadbf5539)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/GroupManagerTest.java (version 438609ece689c93f3ffd47428f2063daadbf5539)
  • Dan Caseley <dan@caseley.me.uk>

    Dan Caseley <dan@caseley.me.uk> 72abac686693f2707b3057b1a2f94ec4af2e660f

    OF-2383: Protect against setting a description on a non-existent group

    • xmppserver/src/main/java/org/jivesoftware/openfire/group/DefaultGroupProvider.java (version 72abac686693f2707b3057b1a2f94ec4af2e660f)
    • xmppserver/src/test/java/org/jivesoftware/openfire/group/DefaultGroupProviderTest.java (version 72abac686693f2707b3057b1a2f94ec4af2e660f)
  • Guus der Kinderen

    Guus der Kinderen c910e44f937f2dbffec166ad647b09dae51af466

    Refactor of 'contact list sharing'
    To separate concerns, other code in Openfire should not need to work with Group-defined raw properties to determine the status of contact list / group sharing. This commit adds a bit of API that (mostly) hides these internals.

    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/group/AddGroup.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/group/GetListGroups.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/admin/group/UpdateGroup.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/Group.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/GroupManager.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/group/SharedGroupVisibility.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQSharedGroupHandler.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/roster/Roster.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/roster/RosterItem.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/java/org/jivesoftware/openfire/roster/RosterManager.java (version c910e44f937f2dbffec166ad647b09dae51af466)
    • xmppserver/src/main/webapp/group-edit.jsp (version c910e44f937f2dbffec166ad647b09dae51af466)