Build #1,138

Plan branch:

Build: #1138 failed

Job: Mac Build Workflow failed

Stages & jobs

  1. Build and Package

Code commits

Openfire (master)

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 5e3cc39592c4a8da8f20c8b60d2bd686cb730b98

    Merge pull request #2014 from guusdk/OF-2406_phase-out-calendarjs
    OF-2406: Remove CalendarJS

  • Guus der Kinderen

    Guus der Kinderen 8b6c743ec8a06eb73b5d78868356e2846fb0c363

    OF-2380: Replace List-based cache values with Set in InMemoryPubsubPersistenceProvider
    The List-based values make for inefficient lookups, while the order that they define is not used (when OF-2379's fix is merged).

    This commit replaces the List with a HashSet, which improves performance.

    Note that this commit introduces a change to the Cache definition used by clustering. This shouldn't be included in a minor/patch Openfire release.

    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/InMemoryPubSubPersistenceProvider.java (version 8b6c743ec8a06eb73b5d78868356e2846fb0c363)
  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 4702479a85d22d6c17ef25d73eed316b61fae02f

    Merge pull request #2005 from guusdk/OF-2395_Remove-deprecated-code
    OF-2395: Remove deprecated code

  • Guus der Kinderen

    Guus der Kinderen d84b6acc9bc7ee58b0980a11880811711b6f5735

    OF-2395: Remove deprecated code
    This commit removes code that was marked as being deprecated, if it was straightforward to remove / replace.

    These changes are likely to break older code, but at some point, we'll need to bite the bullet, as the accumulated technical debt was getting pretty high (I've removed code that was marked as deprecated almost a decade ago).

    • xmppserver/src/main/java/org/jivesoftware/admin/LoginLimitManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/admin/PluginFilter.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/admin/SidebarTag.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/admin/SubnavTag.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/admin/TabsTag.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/database/DefaultConnectionProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/database/EmbeddedConnectionProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ConnectionManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/JMXManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/LocalSessionManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ServerPort.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/SessionManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/XMPPServer.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/audit/AuditManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/audit/spi/AuditManagerImpl.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/audit/spi/AuditorImpl.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/auth/AuthToken.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/cluster/NodeID.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/commands/AdHocCommandHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/component/ExternalComponentManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/container/AdminConsolePlugin.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/container/PluginCacheRegistry.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/disco/DiscoInfoProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/entitycaps/EntityCapabilitiesManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/filetransfer/proxy/FileTransferProxy.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/forms/DataForm.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/forms/FormField.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/forms/package-info.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/forms/spi/XDataFormImpl.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/forms/spi/XFormFieldImpl.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQOfflineMessagesHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpBindManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpSessionManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/http/SessionEventDispatcher.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/http/SessionListener.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/interceptor/PacketCopier.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/keystore/CertificateStoreManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/keystore/IdentityStore.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/ldap/LdapGroupProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/mediaproxy/MediaProxyService.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoom.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/MUCRoomHistory.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/MultiUserChatService.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/MultiUserChatServiceImpl.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/multiplex/ConnectionMultiplexerManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ClientStanzaHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ComponentStanzaHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/DNSUtil.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/MulticastDNSService.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/MultiplexerStanzaHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ServerStanzaHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/ServerTrustManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/SocketAcceptThread.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/TLSStreamHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/net/TLSWrapper.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pep/IQPEPHandler.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPService.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pep/PEPServiceManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/DefaultPubSubPersistenceProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/InMemoryPubSubPersistenceProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubModule.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubPersistenceProvider.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubService.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PublishedItem.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/AffiliationTask.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NodeChangeTask.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/NodeTask.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/cluster/SubscriptionTask.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/resultsetmanager/Result.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/resultsetmanager/ResultSet.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/resultsetmanager/ResultSetImpl.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/ConnectionSettings.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalIncomingServerSession.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalOutgoingServerSession.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/session/SoftwareVersionManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/spi/ConnectionListener.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/spi/ConnectionManagerImpl.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/spi/LegacyConnectionAcceptor.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/spi/LocalRoutingTable.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/stanzaid/StanzaIDUtil.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/user/UserManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/openfire/websocket/XmppWebSocket.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/CertificateManager.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/ConcurrentHashSet.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/EmailService.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/JiveConstants.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/JiveGlobals.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/LocaleUtils.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/StringUtils.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/TaskEngine.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/XMLProperties.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/Cache.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/CacheFactory.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/CacheWrapper.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/CaffeineCache.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/DefaultCache.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/DummyExternalizableUtil.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/cache/SerializingCache.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/java/org/jivesoftware/util/log/util/CommonsLogFactory.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/audit-policy.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/connection-managers-settings.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/http-bind.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/login.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/loginToken.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/muc-room-occupants.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/muc-tasks.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/server-db.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/server-props.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/session-details.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/main/webapp/setup/setup-datasource-standard.jsp (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/test/java/org/jivesoftware/openfire/disco/IQDiscoInfoHandlerTest.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/test/java/org/jivesoftware/openfire/user/UserManagerTest.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/test/java/org/jivesoftware/util/StringUtilsTest.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
    • xmppserver/src/test/java/org/jivesoftware/util/XMLPropertiesTest.java (version d84b6acc9bc7ee58b0980a11880811711b6f5735)
  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> aafe711c9d35a9ac44a639841c6f7663a10ed9e0

    Merge pull request #2015 from guusdk/OF-2307_phase-out-tooltipjs
    OF-2307: Replace Tooltip JS with some CSS.

  • Guus der Kinderen

    Guus der Kinderen fe3b7da6608fa2614f7a19ca8d08d6207e538d61

    OF-2307: Replace Tooltip JS with some CSS.

    • xmppserver/src/main/webapp/decorators/setup.jsp (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/js/tooltips/domLib.js (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/js/tooltips/domTT.js (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/js/tooltips/domTT_drag.js (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/js/tooltips/fadomatic.js (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/ldap-group.jsp (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/ldap-server.jsp (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/ldap-user.jsp (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/setup/ldap-group.jspf (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/setup/ldap-server.jspf (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/setup/ldap-user.jspf (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/setup/setup-datasource-standard.jsp (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/setup/setup-host-settings.jsp (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/setup/setup-ldap-user_test.jsp (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/style/ldap.css (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
    • xmppserver/src/main/webapp/style/setup.css (version fe3b7da6608fa2614f7a19ca8d08d6207e538d61)
  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 9971c22a258b81f351c3d99500dfb233828d1702

    Merge pull request #2017 from guusdk/OF-2409_HTML-tags
    OF-2409: Define doctype as HTML 5, remove obsolete attributes

  • daryl herzmann <akrherz@iastate.edu>

    daryl herzmann <akrherz@iastate.edu> 01cc19ee98695af6a52bceba591ea9890e58ebe7

    Merge pull request #2016 from guusdk/OF-2408_Crowd-static-analysis-results
    OF-2408: Fix static analysis warnings in Crowd package

  • Guus der Kinderen

    Guus der Kinderen 471e56a1fd491cd447f89e8613cfa9dbd2814251

    OF-2409: Define doctype as HTML 5, remove obsolete attributes

    • documentation/database-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/database.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/db-integration-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/docker.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/ide-vscode-setup.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/index.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/install-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/ldap-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/overlay.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/pluggable-roster-support-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/plugin-dev-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/protocol-support.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/separating-admin-users-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/source-build.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/ssl-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/translator-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/upgrade-guide.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/wildfire-ent-3_2_0-upgrade.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/wildfire-openfire-upgrade.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • documentation/working-with-openfire.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/LICENSE.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/README.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/changelog.html (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/available-plugins.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/connection-managers-settings.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/connection-settings-advanced.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/connection-settings-external-components.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/connection-settings-socket-c2s.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/connection-settings-socket-s2s.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/decorators/main.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/decorators/setup.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/error-serverdown.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/group-create.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/group-delete.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/group-edit.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/group-summary.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/http-bind.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/index.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/js/scriptaculous.js (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/ldap-group.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/ldap-server.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/ldap-user.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/log.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/login.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/loginToken.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/logviewer.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/muc-room-summary.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/plugin-admin.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/pubsub-node-summary.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/security-audit-viewer-jsp.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/server-props.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/session-summary.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/ldap-group.jspf (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/ldap-server.jspf (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/ldap-user.jspf (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/setup-admin-settings.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/setup-datasource-jndi.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/setup-finished.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/setup-host-settings.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/setup/setup-ldap-user_test.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/system-cache-details.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/system-cache.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/system-clustering.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/system-emailtest.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/system-properties.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-create.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-delete.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-groups.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-lockout.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-message.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-password.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-roster-add.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
    • xmppserver/src/main/webapp/user-search.jsp (version 471e56a1fd491cd447f89e8613cfa9dbd2814251)
  • Guus der Kinderen

    Guus der Kinderen fe1c72dd0c0613b50df73f28552214ca2e387a6f

    OF-2408: Fix static analysis warnings in Crowd package
    This resolves warnings generated by LGTM and Intellij in the org.jivesoftware.openfire.crowd package. No functional changes are intended.

    • xmppserver/src/main/java/org/jivesoftware/openfire/crowd/CrowdAdminProvider.java (version fe1c72dd0c0613b50df73f28552214ca2e387a6f)
    • xmppserver/src/main/java/org/jivesoftware/openfire/crowd/CrowdGroupProvider.java (version fe1c72dd0c0613b50df73f28552214ca2e387a6f)
    • xmppserver/src/main/java/org/jivesoftware/openfire/crowd/CrowdManager.java (version fe1c72dd0c0613b50df73f28552214ca2e387a6f)
    • xmppserver/src/main/java/org/jivesoftware/openfire/crowd/CrowdProperties.java (version fe1c72dd0c0613b50df73f28552214ca2e387a6f)
    • xmppserver/src/main/java/org/jivesoftware/openfire/crowd/CrowdUserProvider.java (version fe1c72dd0c0613b50df73f28552214ca2e387a6f)
    • xmppserver/src/main/java/org/jivesoftware/openfire/crowd/CrowdVCardProvider.java (version fe1c72dd0c0613b50df73f28552214ca2e387a6f)
  • Guus der Kinderen

    Guus der Kinderen b4cc48196861ebf532e6e3c718c83bf200621315

    OF-2406: Remove CalendarJS
    This verbose, old library is easily replaced with a simple HTML input element, using the 'date' type.

    Openfire does not use CalendarJS itself, but makes it available to plugins. Plugins need to be updated to remove their dependency on this calendar.

    • xmppserver/src/main/webapp/WEB-INF/decorators.xml (version b4cc48196861ebf532e6e3c718c83bf200621315)
    • xmppserver/src/main/webapp/js/jscalendar/calendar-setup.js (version b4cc48196861ebf532e6e3c718c83bf200621315)
    • xmppserver/src/main/webapp/js/jscalendar/calendar-win2k-1.css (version b4cc48196861ebf532e6e3c718c83bf200621315)
    • xmppserver/src/main/webapp/js/jscalendar/calendar-win2k-cold-1.css (version b4cc48196861ebf532e6e3c718c83bf200621315)
    • xmppserver/src/main/webapp/js/jscalendar/calendar.js (version b4cc48196861ebf532e6e3c718c83bf200621315)
    • xmppserver/src/main/webapp/js/jscalendar/i18n.jsp (version b4cc48196861ebf532e6e3c718c83bf200621315)