Build: #1254 was successful Manual run by daryl herzmann

Build result summary

Details

Completed
Queue duration
2 seconds
Duration
1 minute
Labels
None
Agent
Default Agent
Revision
e219d48232a9965a54099b1437834e6ceeca4089
Total tests
466
Successful since
#749 ()

Tests

Code commits

Author Commit Message Commit date
daryl herzmann <akrherz@iastate.edu> daryl herzmann <akrherz@iastate.edu> e219d48232a9965a54099b1437834e6ceeca4089 Merge pull request #1914 from guusdk/OF-2322_purge-queue-after-s2s-established
OF-2322: Do not re-auth s2s for every queued stanza
Guus der Kinderen Guus der Kinderen 6c6ed0f1007f29ea6ecd3e8b564e460eb28b7f52 OF-2322: Do not re-auth s2s for every queued stanza
When an outgoing s2s session is being established, stanzas addressed to the remote domain are cached. Only the first (and not all) queued packets should attempt to establish the connection.

The original code would attempt to establish a session for each queued stanza, which is handled somewhat gracefully in the sense that the existing session is used. However, an event is fired for each attempt. That event is picked up by an event listener that sends a new stanza to that domain, which causes recursion and a never-empty queue.

With this fix, only the first stanza (or the first stanza after a failure) attempts to establish the connection.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2322Could not obtain issue details from Jira