Build: #1971 was successful Manual run by daryl herzmann

Build result summary

Details

Completed
Queue duration
1 second
Duration
10 minutes
Labels
None
Agent
Default Agent
Revision
c2d1f97e2a09642056ca8f6519959d2b52ee447c
Total tests
1378
Successful since
#1969 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen c2d1f97e2a09642056ca8f6519959d2b52ee447c OF-2730: Avoid Dialback being attempted when S2S Strict is enabled
This is a bit of a rewrite of NettyOutboundConnectionHandler. It is aimed at having clear, concise outcomes for the various scenarios: either a session is ready to be used, or it is properly abandoned in all of them now.
Guus der Kinderen Guus der Kinderen 1cc8aaa71fc5f033ec81595c4b0c44e15b0698fb OF-2692: Explictly check if S2S Receiving Entity sets StreamID
RFC6120 dictates that during S2S, the Receiving Entity _must_ set a stream ID to the stream header. This commit fails explicitly when that's the case. Prior to this, a NullPointerException was thrown.

It is likely that this commit fixes a symptom rather than the cause of an issue. It appears that the stream-without-ID is sent by Prosody, that's attempting to send a stream error. Openfire might fail to close a socket, after giving up setting up a connection (or something of that nature).

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2692Could not obtain issue details from Jira
Unknown Issue TypeOF-2730Could not obtain issue details from Jira