Build: #1976 was successful Manual run by daryl herzmann
Code commits
Openfire (master)
-
daryl herzmann <akrherz@iastate.edu> 271731d66f6cbdb4eed2fae9997c4daa5bce1b29
Merge pull request #2348 from guusdk/OF-880_NoSuchUser-IQ-handling
OF-880: IQHandlers must comply with RFC 6121 Section 8.5.1 by default -
daryl herzmann <akrherz@iastate.edu> 4895e5da0e54d9f000eb9b4d5d2e31d76de38656
Merge pull request #2352 from guusdk/OF-1394_Pubsub-reload-nodes-after-restart
OF-1395: Pubsub should load its nodes when re-enabled -
daryl herzmann <akrherz@iastate.edu> 971f0da932438ba6e5330b14ba2b171002544583
Merge pull request #2310 from guusdk/OF-2699_PacketRejection-error
OF-2699: Define optional PacketError on PacketRejectedException -
Guus der Kinderen 1c036e8a553bb32c4ecb6d5718ab0e078331f1ce
OF-1395: Pubsub should load its nodes when re-enabled
When disabling a pubsub service, its nodes get unloaded. When re-enabling the service, those nodes should be loaded again.- i18n/src/main/resources/openfire_i18n.properties (version 1c036e8a553bb32c4ecb6d5718ab0e078331f1ce)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 1c036e8a553bb32c4ecb6d5718ab0e078331f1ce)
- xmppserver/src/main/java/org/jivesoftware/openfire/pubsub/PubSubModule.java (version 1c036e8a553bb32c4ecb6d5718ab0e078331f1ce)
- xmppserver/src/main/webapp/pubsub-node-summary.jsp (version 1c036e8a553bb32c4ecb6d5718ab0e078331f1ce)
-
daryl herzmann <akrherz@iastate.edu> 48aeedbeab739fb041423ed5d79ff5276d7bbcd9
Merge pull request #2351 from guusdk/OF-1399_AdminConsole-pubsub-maxnumberofitems
OF-1399: PubSub Admin Console - Max number of items to persist config -
akrherz <akrherz@iastate.edu> 35b5c62df05faf000ba349786d2269a2ac2e8ca7
nit: add semicolon
- xmppserver/src/main/webapp/pubsub-node-edit.jsp (version 35b5c62df05faf000ba349786d2269a2ac2e8ca7)
-
daryl herzmann <akrherz@iastate.edu> c7d9421ccd0e555b9d164a46dd8eb3ec8f55a854
Merge pull request #2350 from guusdk/OF-1406-AdminConsole-S2STest-output-readonly
OF-1406: Admin Console S2S Connection Test output should be read-only -
Guus der Kinderen 885c8dd2f8351a9f5470c7b5f9262fad21a3068f
OF-1399: PubSub Admin Console - Max number of items to persist config
'Max number of items' is now only configurable when 'persist items' is enabled.- xmppserver/src/main/webapp/pubsub-node-edit.jsp (version 885c8dd2f8351a9f5470c7b5f9262fad21a3068f)
-
Guus der Kinderen f3bc54fdac9afa1362a7162538dabacdf358e30d
OF-1406: Admin Console S2S Connection Test output should be read-only
Still allows the content to be copied.- xmppserver/src/main/webapp/server-connectiontest.jsp (version f3bc54fdac9afa1362a7162538dabacdf358e30d)
-
Guus der Kinderen 3c658c44e632f99f6bc78ffd2c0940a501ee62c0
OF-880: IQHandlers must comply with RFC 6121 Section 8.5.1 by default
This builds on a previous attempt to add support for IQ handling with regards to RFC 6121 Section 8.5.1 (No Such User), which was added in 15e6c5619d6ade7c40de95a1a7a158b1a9358ff0 and got partially reverted in 637cc81733092275c2726b43ebe603c0cbd438fe
The original fix got reverted, because pre-existing code (in IQHandlers of plugins) depends on non-compliant behavior.
With this new commit, I'm re-introducing the fix, but am adding a mechanism for individual plugins to opt out.- xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version 3c658c44e632f99f6bc78ffd2c0940a501ee62c0)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQHandler.java (version 3c658c44e632f99f6bc78ffd2c0940a501ee62c0)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQSessionEstablishmentHandler.java (version 3c658c44e632f99f6bc78ffd2c0940a501ee62c0)
-
Guus der Kinderen 44349ac44fc98d9e9e474305ae0f5b8c4d219856
OF-880: No Such User detection to evaluate pre-authenticated session
A pre-authenticed session should not be consided a 'no such user' case.
Given the implementation, it's hard to identify a pre-authenticated session based on a (bare JID) 'to' address. The API is designed to be used by 'from' addresses.
Pre-authenticated sessions are unlikely to be the subject of a query, unless it is the client itself issuing the query. Aioxmpp's tests have been observed to perform disco/info requests prior to authentication. Given this, we can use the 'from' address (full JID) if its bare JID matches the addressee for the 'no such user' detection.- xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version 44349ac44fc98d9e9e474305ae0f5b8c4d219856)
- xmppserver/src/main/java/org/jivesoftware/openfire/handler/IQHandler.java (version 44349ac44fc98d9e9e474305ae0f5b8c4d219856)
-
Guus der Kinderen f4287c449a997a4382afa667bce3f90257fa9a78
OF-1405: Fix trim of trailing slash
- xmppserver/src/main/webapp/server-connectiontest.jsp (version f4287c449a997a4382afa667bce3f90257fa9a78)
-
Guus der Kinderen 4a80408b43a47db8022821a97d44ab80694bd04a
OF-1405: Validate XMPP domain field of S2S Tester in admin console
When the end-user provides an invalid value, try to correct for common mistakes, or show a nicer error message.- i18n/src/main/resources/openfire_i18n.properties (version 4a80408b43a47db8022821a97d44ab80694bd04a)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 4a80408b43a47db8022821a97d44ab80694bd04a)
- xmppserver/src/main/java/org/jivesoftware/util/S2STestService.java (version 4a80408b43a47db8022821a97d44ab80694bd04a)
- xmppserver/src/main/webapp/server-connectiontest.jsp (version 4a80408b43a47db8022821a97d44ab80694bd04a)
-
Guus der Kinderen cf4026c9b369bd506632a797ad53a32c7080e4d6
OF-1405: Detect usage of local components
- xmppserver/src/main/webapp/server-connectiontest.jsp (version cf4026c9b369bd506632a797ad53a32c7080e4d6)
-
Guus der Kinderen 82d7c32f4ae86745b25c037211ca66f6945ec923
OF-2735: Admin Console: fix title on TLS store details page
... and added a bit of Dutch translation.- i18n/src/main/resources/openfire_i18n.properties (version 82d7c32f4ae86745b25c037211ca66f6945ec923)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 82d7c32f4ae86745b25c037211ca66f6945ec923)
- xmppserver/src/main/webapp/security-certificate-details.jsp (version 82d7c32f4ae86745b25c037211ca66f6945ec923)
-
Guus der Kinderen 120cd4ceb9cb340c44820484977cd6bbde55feb2
OF-1382: Admin console should not autocomplete username/password in all forms
Auto-complete is helpful when logging into the admin console, but it is not helpful when creating new users or other forms where usernames and/or passwords are to be provided to create something new (like a MUC room).- xmppserver/src/main/webapp/group-edit.jsp (version 120cd4ceb9cb340c44820484977cd6bbde55feb2)
- xmppserver/src/main/webapp/muc-room-edit-form.jsp (version 120cd4ceb9cb340c44820484977cd6bbde55feb2)
- xmppserver/src/main/webapp/user-create.jsp (version 120cd4ceb9cb340c44820484977cd6bbde55feb2)
- xmppserver/src/main/webapp/user-password.jsp (version 120cd4ceb9cb340c44820484977cd6bbde55feb2)
- xmppserver/src/main/webapp/user-search.jsp (version 120cd4ceb9cb340c44820484977cd6bbde55feb2)
-
Guus der Kinderen 542147b22edec8ede582656d657a91f6796d9d16
OF-2734: Fix exception on PubSub Node config admin console page
- xmppserver/src/main/webapp/pubsub-node-configuration.jsp (version 542147b22edec8ede582656d657a91f6796d9d16)
-
Guus der Kinderen 4275bbc2df48594d4f6dfd0edc9abc21b462ca71
OF-1389: Admin Console - PubSub Node ID should be clickable
To be consistent with other admin console summary pages, the identifier of nodes on the PEP and Pubsub Node summary pages should be clickable.
This commit replaces the 'config' column with a link on the pre-existing node ID.- i18n/src/main/resources/openfire_i18n.properties (version 4275bbc2df48594d4f6dfd0edc9abc21b462ca71)
- i18n/src/main/resources/openfire_i18n_fr.properties (version 4275bbc2df48594d4f6dfd0edc9abc21b462ca71)
- i18n/src/main/resources/openfire_i18n_nl.properties (version 4275bbc2df48594d4f6dfd0edc9abc21b462ca71)
- i18n/src/main/resources/openfire_i18n_uk_UA.properties (version 4275bbc2df48594d4f6dfd0edc9abc21b462ca71)
- xmppserver/src/main/webapp/pubsub-node-summary.jsp (version 4275bbc2df48594d4f6dfd0edc9abc21b462ca71)
-
Guus der Kinderen fe3b2c17884b4acd7bc1c49668038911ddf6a0e2
OF-2733: Sync Openfire's truststore with Mozilla's shipped CAs
Before we cut a new release, let’s make sure that we update the content of our truststore with the latest CAs. We traditionally use the ones from Mozilla.
Dan created a handy script for this task. You can find it in the build directory.
This commit replaces the truststore with one that's created with that script.- distribution/src/security/truststore (version fe3b2c17884b4acd7bc1c49668038911ddf6a0e2)
-
Guus der Kinderen 0c10d9acdafbd74484775db75baeeefbc5f8718d
OF-1407: Admin console should have a visual indicator when S2S test is running
The S2S test is a potentially long-running process. The admin console should show some kind of indicator that something is happening.
This is my poor attempt at adding a spinner. There will be much better approaches, but this is what my limited experience gets you within the amount of time I'd like to spend on something like this. Feel free to improve on this! :)- xmppserver/src/main/webapp/server-connectiontest.jsp (version 0c10d9acdafbd74484775db75baeeefbc5f8718d)
-
Guus der Kinderen 289b9ca52fd7dc3bbd692a66f3e57bf23e362f80 m
OF-2699: Define optional PacketError on PacketRejectedException
This change allows a PacketError to be added to the exception that is used to reject (incoming) stanzas in PacketInterceptors. This new field is used in the error that's sent back to the sender, allowing for more detailed error reporting.- xmppserver/src/main/java/org/jivesoftware/openfire/IQRouter.java (version 289b9ca52fd7dc3bbd692a66f3e57bf23e362f80)
- xmppserver/src/main/java/org/jivesoftware/openfire/MessageRouter.java (version 289b9ca52fd7dc3bbd692a66f3e57bf23e362f80)
- xmppserver/src/main/java/org/jivesoftware/openfire/PresenceRouter.java (version 289b9ca52fd7dc3bbd692a66f3e57bf23e362f80)
- xmppserver/src/main/java/org/jivesoftware/openfire/interceptor/PacketRejectedException.java (version 289b9ca52fd7dc3bbd692a66f3e57bf23e362f80)