Build: #2208 was successful Scheduled with changes by Guus der Kinderen

Build result summary

Details

Completed
Queue duration
14 minutes
Duration
27 minutes
Labels
None
Agent
ip-172-31-27-151.eu-central-1.compute.internal
Revision
3a32ce998f9c151c9fcb99951d3a1174fb9a8783
Total tests
1404
Successful since
#2204 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 3a32ce998f9c151c9fcb99951d3a1174fb9a8783 OF-2814: Ensure that multi-byte characters in the XMPP data are parsed properly
Prioer to this change, parsing errors occurred when multi-byte characters where provided to the parser byte-by-byte (or in byte arrays where a multi-byte character was split over more than one byte array).

This commit re-introduces the fix for this problem that was created under OF-458. It uses a CharsetDecoder that will only read 'enough' bytes from an array, leaving bytes that form an incomplete character in the byte array (to be processed in the next iteration, when hopefully more data was added).

The original fix is refactored a little to account for the different API that is provided by Netty (as compared to the old MINA based code), and to facilitate unit testing (of which a couple are added).
Guus der Kinderen Guus der Kinderen 4daaf50e05dfd1b90f3749ab1a995e84e04dcc15 OF-2833: Fix serialization of User when date properties are null
Since OF-2768, various 'date'-based properties of the User class are more likely to be null (especially in context of LDAP/AD).

In this commit, a serialization issue is fixed that is triggered by these null-values.
Guus der Kinderen Guus der Kinderen 009019b7edc72a577b82f9f2b051a01ae3fcde89 OF-2832: When merging data, handle null values
When merging VCard data, if either the left-hand or right-hand side data is null, simply return the other bit. The code already did this in one direction, but now does it for the other direction too.

This allows a VCard for a non-existing user to be set (which fixes setting avatars for MUC rooms).
Guus der Kinderen Guus der Kinderen 1a7c4fd96ba690e6005225fb8aaddaed10044d5b LDAP: reduce log verbosity when requesting data for unknown user.
Guus der Kinderen Guus der Kinderen 07ecd07ad87a2b09863cabdb6d02c05da261317c OF-2827: JDBCAuthProvider should not lowercase/trim provided username
By lowercasing the input, a username with a capital letter can't be used.

The closely related JDBCUserProvider does not lowercase/trim values. It is probably best that both providers treat usernames in the same way.

Jira issues

IssueDescriptionStatus
11 more issues…
Unknown Issue TypeOF-458Could not obtain issue details from Jira
Unknown Issue TypeOF-2768Could not obtain issue details from Jira
Unknown Issue TypeOF-2814Could not obtain issue details from Jira
Unknown Issue TypeOF-2824Could not obtain issue details from Jira
Unknown Issue TypeOF-2825Could not obtain issue details from Jira

Shared artifacts

Artifact File size
.rpm files 48 MB