Build #2,456

Plan branch:

Build: #2456 failed Manual run by Guus der Kinderen

Stages & jobs

  1. Build and Package

Build result summary

Details

Completed
Queue duration
1 second
Duration
8 minutes
Labels
None
Agent
bamboo-agent-iowa.igniterealtime.org 2
Revision
8c2164f975fac92edf87a97f604c82d8aa8ca26b
Total tests
1740
Fixed in
#2457 (Manual run by Guus der Kinderen)
No failed test found. A possible compilation error occurred.

Tests

Responsible

  • Guus der Kinderen Guus der Kinderen Automatically assigned

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 8c2164f975fac92edf87a97f604c82d8aa8ca26b OF-2793: Bundle an Oracle database driver
Given changes in the Oracle license, we can now bundle their database drivers with Openfire. The changes in this commit do just that.

I've opted to use ojdbc11-production rather than ojdbc17-production as the latter is documented to be compatible with Jakarta. We do not use Jakarta. ojdbc11 has been documented to be compatible with Java 17 and 21, which should be good enough for us for now.

Jetty's JSP compiler plugin is not happy with the standard Oracle dependencies. It fails on expecting but not finding oracle.i18n.util.LocaleMapper. The internet suggests that this is caused by Oracle's xmlparserv2 dependency. Excluding that 'fixes' the problem. I'm not sure what functionality this affects.

As a side-effect, the `lib` folder of a distribution now contains an unneeded POM file. I can't find an easy way to exclude that.
Guus der Kinderen Guus der Kinderen cae3519540ed0267e11374c5002ee9572c27d621 OF-2437: Improve CachingPubsubPersistenceProvider (#2664)
* OF-2437: Introduce CachingPubsubPersistenceProviderTest

These new unit tests verify behavior of CachingPubsubPersistenceProvider (which fails, as indicated by some of these test failing).

The tests introduced here cover four types of operations that are being scheduled by the implementation:
- Node creation/changing/removal
- Subscription creation/update/removal
- Affiliation creation/update/removal
- publishing/removal of items

* OF-2437: Fix various issues in CachingPubsubPersistenceProvider

The changes in this commit address the issues that are exposed in the unit tests that are added in the previous commit.

* Update xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProviderItemOperationsTest.java

Co-authored-by: Dan Caseley <dan@caseley.me.uk>

* Update xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProviderAffiliationOperationsTest.java

Co-authored-by: Dan Caseley <dan@caseley.me.uk>

* Update xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProviderItemOperationsTest.java

Co-authored-by: Dan Caseley <dan@caseley.me.uk>

* Update xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProviderNodeOperationsTest.java

Co-authored-by: Dan Caseley <dan@caseley.me.uk>

* Update xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProviderItemOperationsTest.java

Co-authored-by: Dan Caseley <dan@caseley.me.uk>

* Update xmppserver/src/test/java/org/jivesoftware/openfire/pubsub/CachingPubsubPersistenceProviderAffiliationOperationsTest.java

Co-authored-by: Dan Caseley <dan@caseley.me.uk>

---------

Co-authored-by: Dan Caseley <dan@caseley.me.uk>
Guus der Kinderen Guus der Kinderen 36108e269b45eafef28f9e46665219091cf302c7 OF-2722 OF-2902: Remove commons-fileupload
The commons-fileupload dependency that is used by Openfire has a CVE reported against it (rather: against one of its dependencies).

Java/Jetty can nowadays natively process file uploads. There no longer is a need for commons-fileupload.

This commit replaces commons-fileupload, which resolves the outstanding CVE report.

Additionally some plugin-upload properties were slightly refactored.
Guus der Kinderen Guus der Kinderen 483c21d0d195f3125c753bb0db0b3e43e9bbf431 OF-2722: Remove unused plugin download code
By moving JSP code into a servlet, static analyzers are finding more issues. One of the reported issues based on the change in the previous commit is that unsanitized user-provided input is used in the code that implements the downloading of plugins.

This particular code isn't used at all by the admin console. I've removed it in this commit.
Guus der Kinderen Guus der Kinderen baa798c3fddfc6830c27b0c3b2f24ba26da9df51 OF-2959: Plugin download in audit log
Plugin uploads were already added to the audit log. With this change, whenever an admin downloads a plugin, an entry is added to the audit log too.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2437Could not obtain issue details from Jira
Unknown Issue TypeOF-2722Could not obtain issue details from Jira
Unknown Issue TypeOF-2793Could not obtain issue details from Jira
Unknown Issue TypeOF-2902Could not obtain issue details from Jira
Unknown Issue TypeOF-2959Could not obtain issue details from Jira

Error summary for RPM Workflow

The job generated some errors, drill down into the full build log for more details.


OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


Critical Error! The home directory has not been configured,
which will prevent the application from working correctly.


+ set -e
+ env
+ date '+%a %b %d %Y'
+ PATH=/opt/maven/bin:/usr/bin:/bin
+ export PATH
+ pwd
+ sh build/rpm/build_rpms.sh
+ umask 022
+ cd /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILD
+ cd /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILD
+ rm -rf openfire
+ /usr/bin/gzip -dc /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/SOURCES/openfire.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd openfire
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ RPM_EC=0
++ jobs -p
+ exit 0
+ umask 022
+ cd /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILD
+ cd openfire
+ RPM_EC=0
++ jobs -p
+ exit 0
+ umask 022
+ cd /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILD
+ '[' /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch '!=' / ']'
+ rm -rf /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch
++ dirname /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch
+ mkdir -p /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT
+ mkdir /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch
+ cd openfire
+ rm -rf /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch
+ mkdir -p /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt
+ cp -R . /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire
+ mkdir -p /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/etc/init.d
+ cp /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/extra/redhat/openfire /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/etc/init.d/openfire
+ chmod 755 /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/etc/init.d/openfire
+ chmod 755 /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/openfire.sh
+ mkdir -p /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/etc/sysconfig
+ cp /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/extra/redhat/openfire-sysconfig /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/etc/sysconfig/openfire
+ cp changelog.html /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/
+ cp LICENSE.html /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/
+ cp README.html /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/
+ chmod 755 /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/extra/openfired
+ chmod 755 /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/extra/redhat-postinstall.sh
+ mv /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/extra/embedded-db.rc /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin
+ mv /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/extra/embedded-db-viewer.sh /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin
+ rm -rf /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/extra
+ rm -f /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/bin/openfire.bat
+ rm -rf /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/resources/nativeAuth/osx-ppc
+ rm -rf /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/resources/nativeAuth/win32-x86
+ rm -f '/home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/lib/*.dll'
+ rm -f /home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/BUILDROOT/openfire-5.0.0-0.1.20250207snapshot.noarch/opt/openfire/conf/openfire-demoboot.xml
+ /usr/lib/rpm/check-buildroot
error: Installed (but unpackaged) file(s) found:
   /opt/openfire/lib/ojdbc11-production-23.7.0.25.01.pom
    Installed (but unpackaged) file(s) found:
   /opt/openfire/lib/ojdbc11-production-23.7.0.25.01.pom
mv: cannot stat '/home/bamboo-agent2/bamboo-agent-home/xml-data/build-dir/OPENFIRE-NMRB-JOB1/rpmbuild/RPMS/noarch/openfire*rpm': No such file or directory