Build: #2483 was successful Manual run by Guus der Kinderen

Stages & jobs

  1. Build and Package

Build result summary

Details

Completed
Queue duration
1 second
Duration
8 minutes
Labels
None
Agent
bamboo-agent-iowa.igniterealtime.org 3
Revision
926a26a514b39b48a5f612830f54990e5e6c558f
Total tests
1742
Successful since
#2457 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 9dddd3d8ce81839f2d5ae5702254700ea6825562 OF-3031: LocalSession isClosed 'old' implementation through configuration
The change made to `LocalSession#isClosed()` under OF-3031 seems to be the 'correct' change, but this change is likely to introduce issues with code that depends on the old behavior.

To allow for backwards compatibility, this commit introduces a configuration property `xmpp.session.isclose.connectionbased` that can be used to restore the old behavior. By default, the old behavior will be disabled, but this can be changed by changing the value of this property to `true`.
Guus der Kinderen Guus der Kinderen 0d809b9e8a0e95c12ca2b3c03456d7e035551ad5 OF-3031: Session's 'close' state no longer based on its backing connection
In the early days, a Session was always backed by a (socket) connection. When the connection was closed, so was the session, and vice versa.

With Stream Management, this no longer is the case. A session can remain unclosed (detached) while its connection is closed.

This commit changes the behavior of `LocalSession#isClosed()` to be based on the session's `status` field, and no longer on the connection's connectivity state.
Guus der Kinderen Guus der Kinderen 926a26a514b39b48a5f612830f54990e5e6c558f OF-3031: Update Javadoc to distinguish between session and connection.
Guus der Kinderen Guus der Kinderen 510c8429ca51f5fd80e952a6901dac9abf85c188 OF-3030: Adjust log level of "setting locale to"
It's not something that needs to be warned about, it's informational.
Guus der Kinderen Guus der Kinderen 1f1bc62a01c3e6067c53f4198db4df600701a610 OF-3029: Prevent false warnings about data inconsistency
It appears that this warning is also logged (incorrectly) in a scenario where user has a session that relates to a different route (in other words: when the user is using more than one device / the addressing uses different resource-parts in their JIDs). Openfire should not be logging that warning in such cases.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2808Could not obtain issue details from Jira
Unknown Issue TypeOF-2811Could not obtain issue details from Jira
Unknown Issue TypeOF-3029Could not obtain issue details from Jira
Unknown Issue TypeOF-3030Could not obtain issue details from Jira
Unknown Issue TypeOF-3031Could not obtain issue details from Jira

Shared artifacts

Artifact File size
.rpm files 61 MB