Build: #2495 was successful Manual run by Guus der Kinderen

Stages & jobs

  1. Build and Package

Build result summary

Details

Completed
Queue duration
1 second
Duration
9 minutes
Labels
None
Agent
bamboo-agent-iowa.igniterealtime.org 3
Revision
197cd5fee75cbcd9d598304e8731d5089a1790a5
Total tests
1742
Successful since
#2457 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen 197cd5fee75cbcd9d598304e8731d5089a1790a5 OF-3041: Prevent Deadlock by reworking `LocalSession#canDeliver()`
Introduces an alternative to `LocalSession#canProcess`: `#canDeliver`, to fix:
- no longer generate two error stanzas if `LocalOutgoingServerSession#canProcess` returns `false`
- have implemenations be responsible for generating any error stanzas, making it possible for each implemenation to choose the best type of error. No longer assume that every error must be related to XEP-0016.
- prevent synchronous error processing in `LocalOutgoingServerSession` that can introduce a deadlock (similar to OF-2341 and OF-2342).

This commit replaces `#canProcess` but marks it as being deprecated. The replacement method, `#canDeliver` has temporarily received a default implementation that is backwards compatible with the preexisting code. This should allow any third-party implementations to be able to gracefully migrate. In future versions of Openfire `#canProcess` will be removed, and the definition of `#canDeliver` will be changed: instead of a default implementation, it will only be an interface definition of a method (`public boolean canDeliver(@Nonnull final Packet stanza);`)

(see OF-3041">https://igniterealtime.atlassian.net/browse/OF-3041 for more details)
Guus der Kinderen Guus der Kinderen 2bc24a92752bee8d954e505e587f26c35e031b6f OF-2717: Remove JasperInitializer from BOSH context
Earlier commits for this issue have removed the same initializer elsewhere.

See mailinglist thread starting at https://www.eclipse.org/lists/jetty-users/msg10880.html

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-2341Could not obtain issue details from Jira
Unknown Issue TypeOF-2342Could not obtain issue details from Jira
Unknown Issue TypeOF-2717Could not obtain issue details from Jira
Unknown Issue TypeOF-3041Could not obtain issue details from Jira
Unknown Issue TypeXEP-0016Could not obtain issue details from Jira

Shared artifacts

Artifact File size
.rpm files 61 MB