Build: #2903 was successful Scheduled with changes by Guus der Kinderen

Stages & jobs

  1. Build and Package

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
12 minutes
Labels
None
Agent
mesonet-ah.agron.iastate.edu
Revision
37847f59ecf08bbe7e3b0961025aedc84d473d46
Total tests
2002
Successful since
#2899 ()

Tests

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen dd49e6f4a72e153e70fbdf723013f98022e44ef6 OF-3258: Guard against user enumeration in ScramSha1SaslServer
This replaces the use of randomly generated salts for unknown users with a deterministic but cryptographically unpredictable value derived from the username and a server-side secret.

Prior to this change, a non-deterministic salt was used, which can be used (by retrieving it more than once) to determine if a user exists.
Guus der Kinderen Guus der Kinderen f2b03b999e6974e52fa583e8f2400a3690e82417 OF-3258 (code review): Guard against misbehaving AuthProviders
When an AuthProvider cannot return a password, it should throw one of the exceptions defined in the contract, rather than return a null password.

This change guards against misbehaving providers that return null, by interpreting null in the same way as a non-existent user and/or missing support for password retrieval.
Guus der Kinderen Guus der Kinderen f1f5245f21d6c0676b5f4496f68506a6c0ba0e9e OF-3258 (code review): Fake salts should be similar in size to real ones
The usage of fake salts is to avoid attackers to determine if a username exists. For this to work, the salts need to be indistinguishable from real ones. Using the same size for both helps.
Guus der Kinderen Guus der Kinderen 939df3c87aaf05aac0f716ea70b86d0a494c0254 OF-3257/OF-3258: Improve one-time initialization of SERVER_SECRET_NONEXISTENT_USERS
The previous method for one-time initialization of the SERVER_SECRET_NONEXISTENT_USERS property (which depended on a static initializer block) proved to be fragile.

In this commit, initialization happens in a getter that should be used instead of directly accessing the property.
Guus der Kinderen Guus der Kinderen a3f388203cb9acf38eb29acb92bf92a27d19b405 OF-3257/OF-3258 (code review): Spelling: 'nonexisting' -> 'nonexistent'

Jira issues

IssueDescriptionStatus
Unknown Issue TypeOF-3257Could not obtain issue details from Jira
Unknown Issue TypeOF-3258Could not obtain issue details from Jira

Shared artifacts

Artifact File size
.rpm files 75 MB