Openfire (master)

• 

  Guus der Kinderen 07 Dec 2022 317e0659aa3be5c50a18ccd44697338e4d37cc41

  OF-2556: Add unit tests and rename method

  • xmppserver/src/main/java/org/dom4j/io/XMPPPacketReader.java (version 317e0659aa3be5c50a18ccd44697338e4d37cc41)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java (version 317e0659aa3be5c50a18ccd44697338e4d37cc41)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalComponentSession.java (version 317e0659aa3be5c50a18ccd44697338e4d37cc41)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalConnectionMultiplexerSession.java (version 317e0659aa3be5c50a18ccd44697338e4d37cc41)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalIncomingServerSession.java (version 317e0659aa3be5c50a18ccd44697338e4d37cc41)
  • xmppserver/src/test/java/dom/io/XMPPPacketReaderTest.java (version 317e0659aa3be5c50a18ccd44697338e4d37cc41)
• 

  Guus der Kinderen 07 Dec 2022 5dbf2a7699e7165177a9f8294b0879648bc5bb7d

  OF-2556: Record namespace prefixes sent on root XML element
  XMPP connections take the form of an XML document, starting with a 'stream' root element.
  
  Openfire processes the direct child elements as if they were individual documents (for reasons beyond the scope of this issue). In that approach, any namespaces defined in the original root element are lost.
  
  Generally, this isn't much of an issue, as a default namespace is assumed/used that is specific to the connection type. However, if the root element defined _other_ issues, that information is lost.
  
  Defining additional namespaces is allowed in XML/XMPP, but isn't typically used. If it were, we would have hit problems long ago. There is one known application of this, which is Dialback (refactoring Openfire's S2S server to use MINA as part of OF-1112 is how this issue was found).
  
  Openfire should be able to XML-parse child elements of the root 'stream' tags, if those child elements use a prefix that refers to a namespace defined on that root element.
  
  This commit achieves that, by recording such declarations in the `Connection` representation over which they were sent. When such declarations are found, each stanza that is processed is wrapped in dummy root element, on which those definitions are placed, prioer to XML parsing. After parsing, the root element is discarded again.

  • xmppserver/src/main/java/org/dom4j/io/XMPPPacketReader.java (version 5dbf2a7699e7165177a9f8294b0879648bc5bb7d)
  • xmppserver/src/main/java/org/jivesoftware/openfire/Connection.java (version 5dbf2a7699e7165177a9f8294b0879648bc5bb7d)
  • xmppserver/src/main/java/org/jivesoftware/openfire/net/StanzaHandler.java (version 5dbf2a7699e7165177a9f8294b0879648bc5bb7d)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalClientSession.java (version 5dbf2a7699e7165177a9f8294b0879648bc5bb7d)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalComponentSession.java (version 5dbf2a7699e7165177a9f8294b0879648bc5bb7d)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalConnectionMultiplexerSession.java (version 5dbf2a7699e7165177a9f8294b0879648bc5bb7d)
  • xmppserver/src/main/java/org/jivesoftware/openfire/session/LocalIncomingServerSession.java (version 5dbf2a7699e7165177a9f8294b0879648bc5bb7d)