Build: #2440 was successful
Job: Build was successful
Code commits
Openfire (master)
-
Matthew Vivian <matthew.vivian@surevine.com> daca2cfe2c78425c90fd3a19ca12605f4e31d415
Fix: Correctly clean up OutgoingServerSession
On cleanup of old S2S sessions, the `OutgoingServerSessionListener#onConnectionClose` is called for the outbound connection, at this time the routing table contains a single route, but the route is not removed because the session passed to `OutgoingServerSessionListener#onConnectionClose` as the "`handback`" parameter has an empty `outgoingDomainPairs` field.
So when `OutgoingServerSessionListener#onConnectionClose` tries to `removeServerRoute(domainPair)` by iterating over `session.getOutgoingDomainPairs()` there is no `domainPair` to remove.
Adding the Outgoing Domain Pair to the new session on `transferConnectionToNewSession` allows the route to be cleaned up correctly.- xmppserver/src/main/java/org/jivesoftware/openfire/net/RespondingServerStanzaHandler.java (version daca2cfe2c78425c90fd3a19ca12605f4e31d415)
-
Guus der Kinderen 10d5f8067c9daf3a6ad95b2b0f700b3923cc8730
Prevent deadlock in Netty Outbound S2S
- xmppserver/src/main/java/org/jivesoftware/openfire/net/RespondingServerStanzaHandler.java (version 10d5f8067c9daf3a6ad95b2b0f700b3923cc8730)