Build: #659 was successful
Job: Default Job was successful
gradle: Ensure git command is run projectDir rather than CWD.
The assert on line 659 was causing my build to fail. Two issues caused
gitCommit to be empty.
1. The cmd 'git describe --always --tags --dirty=+' was not given
enough time to complete and had not exited which meant no text in
2. The two git commands on lines 653 and 658 were run from the
CWD of my Eclipse IDE, not the $projectDir which caused git to return
an error 128.
To solve the two issues I added a waitForOrKill method call to
proc (like the srCmd had) and I set the execute to run in $projectDir
which I think was the intent/assumption in the original code.
Also add waitFor on git describe command.
reactor: have synchronized block include peeking at scheduled actions
If we do not peek at the scheduled actions in the reactors
synchronized block, then there is a kind of lost-update problem. While
Ractor.schedule() will call wakeup() on the selector, a thread could
have already determined the value of selectWait, while being blocked
at the start of the synchronized reactor section. Once it is able to
enter the section, it will use an outdated selectWait value.
This leads to scheduled actions not being executed on time.
Thanks to Eng ChongMeng for reporting this and suggesting the fix.
Fix typo in comment
Add Stanza.setNewStanzaId() and ensureStanzaIdSet()
Also deprecate setStanzaId() since it was not clear if this would
create a new stanza ID or just ensure that one is set.
- smack-core/src/main/java/org/jivesoftware/smack/packet/Stanza.java (version e23babf1472f02dd3316a502fca157d192011d3b) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/receipts/DeliveryReceiptRequest.java (version e23babf1472f02dd3316a502fca157d192011d3b) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/VCardManager.java (version e23babf1472f02dd3316a502fca157d192011d3b) (diffs)
- smack-integration-test/src/main/java/org/jivesoftware/smackx/mam/MamIntegrationTest.java (version e23babf1472f02dd3316a502fca157d192011d3b) (diffs)
Remove deprecated methods from Stanza class
- smack-core/src/main/java/org/jivesoftware/smack/packet/Stanza.java (version 30bbdf9fdbb1f0774a4079f7148b236d8dbb83be) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/RTPBridge.java (version 30bbdf9fdbb1f0774a4079f7148b236d8dbb83be) (diffs)
- smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/STUN.java (version 30bbdf9fdbb1f0774a4079f7148b236d8dbb83be) (diffs)