Build: #1696 was successful
Job: Default Job was successful
Code commits
Smack (master)
-
Florian Schmaus <flo@geekplace.eu> f0300dc906089564d57135f791c4e4900cfe224d
Remove deprecated "PacketReplyTimeout" methods in SmackConfiguration
-
Florian Schmaus <flo@geekplace.eu> 35cf094386ea0bcfd617c57e8f0ad4fec9d08b87
sasl-javax: Do not set system properties in SASLGSSAPIMechanism
Smack did this for a long time, since eb56f8a55 ("GSSAPI work by Jay
Kline (SMACK-218)."). Not always in a static block though. But
irregardless this is bad practice as it causes side-effects and may
overrides settings.
For example, one users reports:
java.lang.SecurityException: java.io.IOException: gss.conf (No such file or directory)
at sun.security.provider.ConfigFile$Spi.<init>(ConfigFile.java:137)
at sun.security.provider.ConfigFile.<init>(ConfigFile.java:102)
at sun.reflect.GeneratedConstructorAccessor119.newInstance(Unknown Source) -
Florian Schmaus <flo@geekplace.eu> eeb6c52f7e0907fa38a578c153461af5dffa459b
Move SASL logic into AbstractXMPPConnection
Besides the way the transport handles the stream after SASL
<success/>, the SASL logic is independend from the underlying
transport (BOSH, TCP, …). Hence move it up into
AbstractXMPPConnection.
This also has the benefit that we can make some more methods private
or package-private.
Also introduce XmlStringBuilder.optTextChild(), which causes some
associated changes.- smack-bosh/src/main/java/org/jivesoftware/smack/bosh/XMPPBOSHConnection.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/GenericElementListener.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/NonzaCallback.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SASLAuthentication.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/SmackInitialization.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/fsm/AbstractXmppStateMachineConnection.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/provider/SaslChallengeProvider.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/provider/SaslFailureProvider.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/provider/SaslSuccessProvider.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/sasl/SASLErrorException.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/sasl/SASLMechanism.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/sasl/packet/SaslNonza.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/util/CollectionUtil.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/test/java/org/jivesoftware/smack/provider/SaslProviderTest.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/test/java/org/jivesoftware/smack/sasl/core/SCRAMSHA1MechanismTest.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-core/src/test/java/org/jivesoftware/smack/util/PacketParserUtilsTest.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-experimental/src/main/java/org/jivesoftware/smackx/hoxt/packet/AbstractHttpOverXmpp.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-experimental/src/test/java/org/jivesoftware/smackx/mam/QueryArchiveTest.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-extensions/src/main/java/org/jivesoftware/smackx/delay/packet/DelayInformation.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
- smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java (version eeb6c52f7e0907fa38a578c153461af5dffa459b) (diffs)
-
Florian Schmaus <flo@geekplace.eu> c3247ef006ecb4d274c25b8fd48a3f59b3af3221
Use optElement() instead of optAppend() in StreamInitiation.toXML()
-
Florian Schmaus <flo@geekplace.eu> cf48f125655b009791b54082cb0a34a1361cc8e4
Add INSTANCE shortcut to SmackTestUtil
-
Florian Schmaus <flo@geekplace.eu> 3ee4dd7b3a206829dd4247c1e3a6816b62a8f565
Move SASL authentication state into SASLMechanism
-
Florian Schmaus <flo@geekplace.eu> 1d03cfdc790c627bbed2e79a3266fe8d6d1526b4
checkstyle: Remove redundant whitespace check
The "line contains only whitespace character(s)" check is the same as
the trailing whitespace characters check a few lines below.