Verifies the integrety of the projects, as builds are executed immediately after a code change was detected. This plan provides no artifiacts (use a nightly build instead).

Build: #37 was successful Changes by Guus der Kinderen

Build result summary

Details

Completed
Queue duration
< 1 second
Duration
39 seconds
Labels
None
Agent
Default Agent
Revision
cd10e1e41c5f801005ea665c0ba78df2ece54b71
Total tests
259
Successful since
#33 ()

Tests

  • 0 New failures
  • 0 Existing failures
  • 0 Fixed

Code commits

Author Commit Message Commit date
Guus der Kinderen Guus der Kinderen cd10e1e41c5f801005ea665c0ba78df2ece54b71 TINDER-78: Update SLF4J to 1.7.36
Guus der Kinderen Guus der Kinderen d918605fa321c7d356100d907ecb062531342745 TINDER-79: Upgrade dom4j from 1.6.1 to 2.1.3
Guus der Kinderen Guus der Kinderen fa3c9b41eb0a2b8b7bfbc85fe7df1c56f7cf7063 TINDER-82: Ignore empty formfield values
`org.xmpp.forms.DataForm#addField(java.lang.String, java.lang.String, org.xmpp.forms.FormField.Type)`'s implementation defines that the first argument (`variable`) is optional. It then checks using this method to see if it is set:

```
if (variable != null && variable.trim().length() >= 0) {
    result.setVariable(variable);
}
```

A similar check is done for the second argument (`label`).

The second condition in the if-statement is redundant: if the value is not null, it is assured to have at least 0 length.

This is probably an oversight: I assume that the intention is to check for ‘not empty’.

With the existing implementation, an empty value will cause the value to be used, which might lead to empty attributes or elements. I presume that those are undesirable. A “set to nothing” declaration would be far-fetched and equally defined by not having the attribute/label at all.
Guus der Kinderen Guus der Kinderen d673df1b051e5ecb9646fba35d9dedd6703e05d3 TINDER-81: Fix typo in Roster
The ‘toString’ of the Roster class will include the word subscrption which arguably should be subscription.

toString wouldn’t typically be used for anything other than make humans understand the composition of the instance. In cases where this is not the case, users would benefit from having a correction (although existing users will see a breakage because of this change).
Guus der Kinderen Guus der Kinderen 6c58d23772e6dd07eeaf36068f9e099fbfd0b793 Add missing description of Javadoc tag.

Jira issues

IssueDescriptionStatus
Unknown Issue TypeTINDER-77Could not obtain issue details from Jira
Unknown Issue TypeTINDER-78Could not obtain issue details from Jira
Unknown Issue TypeTINDER-79Could not obtain issue details from Jira
Unknown Issue TypeTINDER-81Could not obtain issue details from Jira
Unknown Issue TypeTINDER-82Could not obtain issue details from Jira