Build: #37 was successful Changes by Guus der Kinderen
Code commits
Plan Repository
-
Guus der Kinderen cd10e1e41c5f801005ea665c0ba78df2ece54b71
TINDER-78: Update SLF4J to 1.7.36
- pom.xml (version cd10e1e41c5f801005ea665c0ba78df2ece54b71)
-
Guus der Kinderen d918605fa321c7d356100d907ecb062531342745
TINDER-79: Upgrade dom4j from 1.6.1 to 2.1.3
- pom.xml (version d918605fa321c7d356100d907ecb062531342745)
-
Guus der Kinderen fa3c9b41eb0a2b8b7bfbc85fe7df1c56f7cf7063
TINDER-82: Ignore empty formfield values
`org.xmpp.forms.DataForm#addField(java.lang.String, java.lang.String, org.xmpp.forms.FormField.Type)`'s implementation defines that the first argument (`variable`) is optional. It then checks using this method to see if it is set:
```
if (variable != null && variable.trim().length() >= 0) {
result.setVariable(variable);
}
```
A similar check is done for the second argument (`label`).
The second condition in the if-statement is redundant: if the value is not null, it is assured to have at least 0 length.
This is probably an oversight: I assume that the intention is to check for ‘not empty’.
With the existing implementation, an empty value will cause the value to be used, which might lead to empty attributes or elements. I presume that those are undesirable. A “set to nothing” declaration would be far-fetched and equally defined by not having the attribute/label at all.- src/main/java/org/xmpp/forms/DataForm.java (version fa3c9b41eb0a2b8b7bfbc85fe7df1c56f7cf7063)
- src/test/java/org/xmpp/forms/DataFormAddingFieldsTest.java (version fa3c9b41eb0a2b8b7bfbc85fe7df1c56f7cf7063)
-
Guus der Kinderen d673df1b051e5ecb9646fba35d9dedd6703e05d3
TINDER-81: Fix typo in Roster
The ‘toString’ of the Roster class will include the word subscrption which arguably should be subscription.
toString wouldn’t typically be used for anything other than make humans understand the composition of the instance. In cases where this is not the case, users would benefit from having a correction (although existing users will see a breakage because of this change).- src/main/java/org/xmpp/packet/Roster.java (version d673df1b051e5ecb9646fba35d9dedd6703e05d3)
-
Guus der Kinderen 6c58d23772e6dd07eeaf36068f9e099fbfd0b793
Add missing description of Javadoc tag.
- src/test/java/org/xmpp/component/DummyAbstractComponent.java (version 6c58d23772e6dd07eeaf36068f9e099fbfd0b793)
-
Guus der Kinderen c3e406912e2fa4f746fcdf95f41227afe18d5b6f
Remove unused pattern from .editorConfig.
- .editorconfig (version c3e406912e2fa4f746fcdf95f41227afe18d5b6f)
-
Guus der Kinderen a3aecda49712680a470c9501b047796653afa2c8
Remove redundant suppression of 'unchecked'.
- src/main/java/org/xmpp/component/ComponentManagerFactory.java (version a3aecda49712680a470c9501b047796653afa2c8)
- src/main/java/org/xmpp/forms/DataForm.java (version a3aecda49712680a470c9501b047796653afa2c8)
-
Guus der Kinderen 9a4eadb5d526534d47e81957e4b61db81bc642aa
Replace StringBuffer with the more performant StringBuilder (available since Java 5).
- src/main/java/org/xmpp/packet/Roster.java (version 9a4eadb5d526534d47e81957e4b61db81bc642aa)
-
Guus der Kinderen 5e282747bb007e95a552161f4e12be80eea79152
Replace String == comparison with call to equals().
- src/test/java/org/xmpp/component/AbstractComponentServiceDiscovery.java (version 5e282747bb007e95a552161f4e12be80eea79152)
-
Guus der Kinderen e8492c08c77db3df6ffb4c2f3cb1589882596658
Do not use pre-sized array in Collection.toArray call
As explained by IntelliJ:
There are two styles to convert a collection to an array:
A pre-sized array, for example, c.toArray(new String[c.size()])
An empty array, for example, c.toArray(new String[0])
In older Java versions, using a pre-sized array was recommended, as the reflection call necessary to create an array of proper size was quite slow.
However, since late updates of OpenJDK 6, this call was intrinsified, making the performance of the empty array version the same, and sometimes even better, compared to the pre-sized version. Also, passing a pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray calls. This may result in extra nulls at the end of the array if the collection was concurrently shrunk during the operation.- src/main/java/org/jivesoftware/util/FastDateFormat.java (version e8492c08c77db3df6ffb4c2f3cb1589882596658)
-
Guus der Kinderen 9225bd21c18ce9629b076ac00b103986987b7ce9
Replace explicit type with diamond (available since Java 7)
- src/main/java/org/xmpp/component/AbstractComponent.java (version 9225bd21c18ce9629b076ac00b103986987b7ce9)
- src/main/java/org/xmpp/forms/DataForm.java (version 9225bd21c18ce9629b076ac00b103986987b7ce9)
- src/main/java/org/xmpp/forms/FormField.java (version 9225bd21c18ce9629b076ac00b103986987b7ce9)
- src/main/java/org/xmpp/packet/Roster.java (version 9225bd21c18ce9629b076ac00b103986987b7ce9)
- src/main/java/org/xmpp/resultsetmanagement/ResultSetImpl.java (version 9225bd21c18ce9629b076ac00b103986987b7ce9)
- src/test/java/org/xmpp/component/AbstractComponentRespondsToIQRequestsTest.java (version 9225bd21c18ce9629b076ac00b103986987b7ce9)
- src/test/java/org/xmpp/component/DummyAbstractComponent.java (version 9225bd21c18ce9629b076ac00b103986987b7ce9)
-
Guus der Kinderen 171d48cbb8ff34753189305b8b0a4f6e23e4f8bd
Add language hint to HTML tag of license file.
- LICENSE.html (version 171d48cbb8ff34753189305b8b0a4f6e23e4f8bd)
-
Guus der Kinderen a9ff1e833a0c20ac1a40eefaae416e2a54363a15
Do not use a loop when not looping.
- src/main/java/org/xmpp/forms/FormField.java (version a9ff1e833a0c20ac1a40eefaae416e2a54363a15)
-
Guus der Kinderen 453f710fbba7bb6bbd837bd83e22d25988f6f896
Collapse identical 'catch' blocks (available since Java 7).
- src/test/java/org/xmpp/packet/JIDCreationDomainTest.java (version 453f710fbba7bb6bbd837bd83e22d25988f6f896)
-
Guus der Kinderen 29457c83589bf2cd00004266dd4dd06789b678fe
Fix incorrect references in Javadoc.
- src/main/java/org/xmpp/component/AbstractComponent.java (version 29457c83589bf2cd00004266dd4dd06789b678fe)
- src/test/java/org/xmpp/packet/JIDSerializabilityTest.java (version 29457c83589bf2cd00004266dd4dd06789b678fe)
-
Guus der Kinderen 9efbbe51558c7db2396fa6134ad19016573ce400
Mark immutable fields as final.
- src/main/java/org/xmpp/forms/FormField.java (version 9efbbe51558c7db2396fa6134ad19016573ce400)
- src/main/java/org/xmpp/packet/IQ.java (version 9efbbe51558c7db2396fa6134ad19016573ce400)
- src/main/java/org/xmpp/packet/PacketError.java (version 9efbbe51558c7db2396fa6134ad19016573ce400)
- src/main/java/org/xmpp/packet/Roster.java (version 9efbbe51558c7db2396fa6134ad19016573ce400)
- src/main/java/org/xmpp/packet/StreamError.java (version 9efbbe51558c7db2396fa6134ad19016573ce400)
-
Guus der Kinderen 4d465ae98c050a694b9f3b3d2da1ab59153be534
Fix a Javadoc reference.
- src/main/java/org/xmpp/component/AbstractComponent.java (version 4d465ae98c050a694b9f3b3d2da1ab59153be534)
-
Guus der Kinderen 55727d42c79812d223c4446574dc16517a89fe33
Remove unchecked calls to raw types.
- src/main/java/org/xmpp/component/ComponentManagerFactory.java (version 55727d42c79812d223c4446574dc16517a89fe33)
- src/main/java/org/xmpp/forms/DataForm.java (version 55727d42c79812d223c4446574dc16517a89fe33)
-
Guus der Kinderen f59931eb141b032b6afc86941aaf78868a81cc8b
Fields in enumeration types are rarely mutable. Should be marked 'final'.
- src/main/java/org/xmpp/forms/FormField.java (version f59931eb141b032b6afc86941aaf78868a81cc8b)
- src/main/java/org/xmpp/packet/PacketError.java (version f59931eb141b032b6afc86941aaf78868a81cc8b)
- src/main/java/org/xmpp/packet/StreamError.java (version f59931eb141b032b6afc86941aaf78868a81cc8b)
-
Guus der Kinderen 963214f2dfa9704d6db297e666fec4aeb42e4b12
Remove redundant 'toString()' call.
- src/main/java/org/xmpp/packet/JID.java (version 963214f2dfa9704d6db297e666fec4aeb42e4b12)
-
Guus der Kinderen d10caa4447def79a07b36be1ebeb4a4c3fdec42a
Remove redundant 'public' modifier on interface method.
- src/main/java/org/xmpp/resultsetmanagement/Result.java (version d10caa4447def79a07b36be1ebeb4a4c3fdec42a)
-
Guus der Kinderen 75a5ec0232edef4989307588eab9fd4124b29519
Replace Collections.sort() with List.sort() (available since Java 8).
- src/main/java/org/xmpp/resultsetmanagement/ResultSetImpl.java (version 75a5ec0232edef4989307588eab9fd4124b29519)
-
Guus der Kinderen 79199528766add1364920248908c2833f6582db0
Private methods cannot be overridden. Marking them 'final' is redundant.
- src/main/java/org/xmpp/component/AbstractComponent.java (version 79199528766add1364920248908c2833f6582db0)
-
Guus der Kinderen ba906f5d4486216b907f75d69e91d698fd5f8393
Remove unneeded semicolons
When Openfire was still built with Ant, there was a document-generating utility ('qdox' maybe?) that would crash if enum definitions did not end with a semicolon. Those days are long gone. We can remove these redundant characters.- src/main/java/org/xmpp/forms/DataForm.java (version ba906f5d4486216b907f75d69e91d698fd5f8393)
- src/main/java/org/xmpp/packet/IQ.java (version ba906f5d4486216b907f75d69e91d698fd5f8393)
- src/main/java/org/xmpp/packet/Message.java (version ba906f5d4486216b907f75d69e91d698fd5f8393)
- src/main/java/org/xmpp/packet/Roster.java (version ba906f5d4486216b907f75d69e91d698fd5f8393)
- src/test/java/org/xmpp/forms/FormFieldGetSetTest.java (version ba906f5d4486216b907f75d69e91d698fd5f8393)
-
Guus der Kinderen 71abbecf0a0cfb18e95216601a99194e78d8da49
Remove redundant 'private' modifier on enum constructors.
- src/main/java/org/xmpp/forms/FormField.java (version 71abbecf0a0cfb18e95216601a99194e78d8da49)
- src/main/java/org/xmpp/packet/PacketError.java (version 71abbecf0a0cfb18e95216601a99194e78d8da49)
- src/main/java/org/xmpp/packet/StreamError.java (version 71abbecf0a0cfb18e95216601a99194e78d8da49)
-
Guus der Kinderen 720944e881cc1420c2409969ec86ab197943d1ed
Remove unneeded conversion to String.
- src/main/java/org/jivesoftware/util/FastDateFormat.java (version 720944e881cc1420c2409969ec86ab197943d1ed)
-
Guus der Kinderen ec4db0f81ce674c1ad897b5ec2550c4514fce5fc
Remove redundant array creation for calling varargs method.
- src/main/java/org/xmpp/component/AbstractComponent.java (version ec4db0f81ce674c1ad897b5ec2550c4514fce5fc)
-
Guus der Kinderen b4a5b842767f589d6179d4fc44fce13462c8acd3
Fix typo in comment.
- src/test/java/org/xmpp/component/AbstractComponentServiceDiscovery.java (version b4a5b842767f589d6179d4fc44fce13462c8acd3)
-
Guus der Kinderen 352934f27935a495e559a884cd3aec8254665cd0
Remove unused import.
- src/main/java/org/xmpp/resultsetmanagement/ResultSet.java (version 352934f27935a495e559a884cd3aec8254665cd0)
-
Guus der Kinderen 32aa8abc9bd0b6d2d7d24cbf6aa3ad957fba1768
TINDER-77: Update Caffeine to 2.9.3
- pom.xml (version 32aa8abc9bd0b6d2d7d24cbf6aa3ad957fba1768)